[coreboot] build service results for r5841

Patrick Georgi patrick at georgi-clan.de
Sat Sep 25 17:19:57 CEST 2010

Am 25.09.2010 16:40, schrieb repository service:
> Change Log:
> Make globals in romstage break the build, so we don't have to
> wonder why variables in .data or .bss (both somewhere in ROM space)
> are wrong.
Instant proof that this test is useful :-)

Digging through these boards, the culprit is
static u8 swaplist[] = { 0xFF, CONFIG_HT_CHAIN_UNITID_BASE,
static BOOL AMD_CB_ManualBUIDSwapList (u8 node, u8 link, u8 **List).

This is put in .data, as it might be modified by some other user of the
pointer. As far as I can see, it isn't, so that choice is harmless.

I made it const, as well as its users, and the tree compiles, but
feedback on the approach of the patch and/or testing is _very_ welcome.

Signed-off-by: Patrick Georgi <patrick.georgi at coresystems.de>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 20100925-4-no-global-vars-on-fam10
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20100925/b067813f/attachment.ksh>

More information about the coreboot mailing list