[coreboot] [commit] r5830 - in trunk: . documentation src src/arch/i386 src/cpu/amd/model_gx2 src/cpu/amd/model_lx src/cpu/x86/32bit src/include/boot src/pc80

repository service svn at coreboot.org
Thu Sep 23 20:48:28 CEST 2010


Author: uwe
Date: Thu Sep 23 20:48:27 2010
New Revision: 5830
URL: https://tracker.coreboot.org/trac/coreboot/changeset/5830

Log:
Whitespace/typo/cosmetic fixes (trivial).

Signed-off-by: Uwe Hermann <uwe at hermann-uwe.de>
Acked-by: Uwe Hermann <uwe at hermann-uwe.de>

Modified:
   trunk/README
   trunk/documentation/POSTCODES
   trunk/src/Kconfig.deprecated_options
   trunk/src/arch/i386/Kconfig
   trunk/src/cpu/amd/model_gx2/cache_as_ram.inc
   trunk/src/cpu/amd/model_lx/cache_as_ram.inc
   trunk/src/cpu/x86/32bit/entry32.inc
   trunk/src/include/boot/coreboot_tables.h
   trunk/src/pc80/usbdebug_serial.c

Modified: trunk/README
==============================================================================
--- trunk/README	Thu Sep 23 20:29:40 2010	(r5829)
+++ trunk/README	Thu Sep 23 20:48:27 2010	(r5830)
@@ -51,7 +51,7 @@
 
 
 Testing coreboot Without Modifying Your Hardware
--------------------------------------------------
+------------------------------------------------
 
 If you want to test coreboot without any risks before you really decide
 to use it on your hardware, you can use the QEMU system emulator to run

Modified: trunk/documentation/POSTCODES
==============================================================================
--- trunk/documentation/POSTCODES	Thu Sep 23 20:29:40 2010	(r5829)
+++ trunk/documentation/POSTCODES	Thu Sep 23 20:48:27 2010	(r5830)
@@ -2,13 +2,13 @@
 coreboot POST Codes
 -------------------------------------------------------------------------------
 
-This is an (incomplete) list of POST codes emitted by coreboot v2.
+This is an (incomplete) list of POST codes emitted by coreboot v4.
 
 0x10 Entry into protected mode
 0x01 Entry into 'crt0.s' reset code jumps to here
-0x11 Start copying LinuxBIOS to RAM with decompression if compressed
+0x11 Start copying coreboot to RAM with decompression if compressed
 0x12 Copy/decompression finished jumping to RAM
-0x80 Entry into LinuxBIOS in RAM
+0x80 Entry into coreboot in RAM
 0x13 Entry into c_start
 0xfe Pre call to hardwaremain()
 0x39 Console is initialized

Modified: trunk/src/Kconfig.deprecated_options
==============================================================================
--- trunk/src/Kconfig.deprecated_options	Thu Sep 23 20:29:40 2010	(r5829)
+++ trunk/src/Kconfig.deprecated_options	Thu Sep 23 20:48:27 2010	(r5830)
@@ -4,45 +4,48 @@
 
 # It might be possible to consolidate hard_reset() to southbridges,
 # given that it (usually) uses its registers.
-# The long term goal would be to eliminate hard_reset from boards.
+# The long term goal would be to eliminate hard_reset() from boards.
 config BOARD_HAS_HARD_RESET
-        bool
-        default n
-        help
-          This variable specifies whether a given board has a reset.c
-          file containing a hard_reset() function.
+	bool
+	default n
+	help
+	  This variable specifies whether a given board has a reset.c
+	  file containing a hard_reset() function.
 
 # It might be possible to consolidate FADTs to southbridges. This would
 # improve code reuse in the tree.
 config BOARD_HAS_FADT
-        bool
-        default n
-        help
-          This variable specifies whether a given board has a board-local
-          FADT in fadt.c. Long-term, those should be moved to appropriate
-          chipset components (eg. southbridge)
+	bool
+	default n
+	help
+	  This variable specifies whether a given board has a board-local
+	  FADT in fadt.c. Long-term, those should be moved to appropriate
+	  chipset components (eg. southbridge).
 
 # There ought to be a better place to put data than code. Also, make this
 # (or a similar) framework more universally usable, so all boards benefit
 # from sharing data between the various tables.
 config HAVE_BUS_CONFIG
-        bool
-        default n
+	bool
+	default n
 	help
 	  This variable specifies whether a given board has a get_bus_conf.c
 	  file containing information about bus routing.
 
-# Will be removed (alongside with the PS2 init code) once payloads
-# reliably support PS2 init themselves.
+# Will be removed (alongside with the PS/2 init code) once payloads
+# reliably support PS/2 init themselves.
 config DRIVERS_PS2_KEYBOARD
-	bool "PS2 Keyboard init"
+	bool "PS/2 keyboard init"
 	default y
 	help
-	  Enable this option to initialize PS2 keyboards found connected
-	  to the PS2 port.  Some payloads (eg, filo) require this
-	  option.  Other payloads (eg, SeaBIOS, Linux) do not require
-	  it.  Initializing a PS2 keyboard can take several hundred
-	  milliseconds.
+	  Enable this option to initialize PS/2 keyboards found connected
+	  to the PS/2 port.
+
+	  Some payloads (eg, filo) require this option.  Other payloads
+	  (eg, SeaBIOS, Linux) do not require it.
+	  Initializing a PS/2 keyboard can take several hundred milliseconds.
+
 	  If you know you will only use a payload which does not require
-	  this option, then you can say "n" here to speed up boot time.
-	  Otherwise say "y".
+	  this option, then you can say N here to speed up boot time.
+	  Otherwise say Y.
+

Modified: trunk/src/arch/i386/Kconfig
==============================================================================
--- trunk/src/arch/i386/Kconfig	Thu Sep 23 20:29:40 2010	(r5829)
+++ trunk/src/arch/i386/Kconfig	Thu Sep 23 20:48:27 2010	(r5830)
@@ -76,10 +76,10 @@
 	default n
 	depends on TINY_BOOTBLOCK
 	help
-		If this option is activate, no new coreboot.rom file
-		is created. Instead it is expected that there already
-		is a suitable file for further processing.
-		The bootblock will not be modified.
+	  If this option is enabled, no new coreboot.rom file
+	  is created. Instead it is expected that there already
+	  is a suitable file for further processing.
+	  The bootblock will not be modified.
 
 config ROMCC
 	bool

Modified: trunk/src/cpu/amd/model_gx2/cache_as_ram.inc
==============================================================================
--- trunk/src/cpu/amd/model_gx2/cache_as_ram.inc	Thu Sep 23 20:29:40 2010	(r5829)
+++ trunk/src/cpu/amd/model_gx2/cache_as_ram.inc	Thu Sep 23 20:48:27 2010	(r5830)
@@ -184,7 +184,7 @@
 	/* clear boot_complete flag */
 	xorl	%ebp, %ebp
 __main:
-	post_code(0x11)		/* post 11 */
+	post_code(0x11)
 
 	/* TODO For suspend/resume the cache will have to live between
 	 * CONFIG_RAMBASE and CONFIG_RAMTOP
@@ -201,7 +201,7 @@
 	call copy_and_run
 
 .Lhlt:
-	post_code(0xee)	/* post fail ee */
+	post_code(0xee)
 	hlt
 	jmp	.Lhlt
 

Modified: trunk/src/cpu/amd/model_lx/cache_as_ram.inc
==============================================================================
--- trunk/src/cpu/amd/model_lx/cache_as_ram.inc	Thu Sep 23 20:29:40 2010	(r5829)
+++ trunk/src/cpu/amd/model_lx/cache_as_ram.inc	Thu Sep 23 20:48:27 2010	(r5830)
@@ -210,7 +210,7 @@
 	/* clear boot_complete flag */
 	xorl	%ebp, %ebp
 __main:
-	post_code(0x11)		/* post 11 */
+	post_code(0x11)
 
 	/* TODO For suspend/resume the cache will have to live between
 	 * CONFIG_RAMBASE and CONFIG_RAMTOP
@@ -227,7 +227,7 @@
 	call copy_and_run
 
 .Lhlt:
-	post_code(0xee)	/* post fail ee */
+	post_code(0xee)
 	hlt
 	jmp	.Lhlt
 

Modified: trunk/src/cpu/x86/32bit/entry32.inc
==============================================================================
--- trunk/src/cpu/x86/32bit/entry32.inc	Thu Sep 23 20:29:40 2010	(r5829)
+++ trunk/src/cpu/x86/32bit/entry32.inc	Thu Sep 23 20:48:27 2010	(r5830)
@@ -51,7 +51,7 @@
 	/* Save the BIST value */
 	movl	%eax, %ebp
 
-	post_code(0x10)	/* post 10 */
+	post_code(0x10)
 
 	movw	$ROM_DATA_SEG, %ax
 	movw	%ax, %ds

Modified: trunk/src/include/boot/coreboot_tables.h
==============================================================================
--- trunk/src/include/boot/coreboot_tables.h	Thu Sep 23 20:29:40 2010	(r5829)
+++ trunk/src/include/boot/coreboot_tables.h	Thu Sep 23 20:48:27 2010	(r5830)
@@ -74,10 +74,10 @@
 	uint32_t table_entries;
 };
 
-/* Every entry in the boot enviroment list will correspond to a boot
+/* Every entry in the boot environment list will correspond to a boot
  * info record.  Encoding both type and size.  The type is obviously
  * so you can tell what it is.  The size allows you to skip that
- * boot enviroment record if you don't know what it easy.  This allows
+ * boot environment record if you don't know what it easy.  This allows
  * forward compatibility with records not yet defined.
  */
 struct lb_record {
@@ -85,9 +85,9 @@
 	uint32_t size;		/* size of record (in bytes) */
 };
 
-#define LB_TAG_UNUSED	0x0000
+#define LB_TAG_UNUSED		0x0000
 
-#define LB_TAG_MEMORY	0x0001
+#define LB_TAG_MEMORY		0x0001
 
 struct lb_memory_range {
 	struct lb_uint64 start;
@@ -108,7 +108,7 @@
 	struct lb_memory_range map[0];
 };
 
-#define LB_TAG_HWRPB	0x0002
+#define LB_TAG_HWRPB		0x0002
 struct lb_hwrpb {
 	uint32_t tag;
 	uint32_t size;

Modified: trunk/src/pc80/usbdebug_serial.c
==============================================================================
--- trunk/src/pc80/usbdebug_serial.c	Thu Sep 23 20:29:40 2010	(r5829)
+++ trunk/src/pc80/usbdebug_serial.c	Thu Sep 23 20:48:27 2010	(r5830)
@@ -1,6 +1,9 @@
 /*
  * This file is part of the coreboot project.
  *
+ * Copyright (C) 2007 AMD
+ * Written by Yinghai Lu <yinghai.lu at amd.com> for AMD.
+ *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
  * the Free Software Foundation; version 2 of the License.




More information about the coreboot mailing list