[coreboot] AMD cache setup is broken

[Marc Jones]

On Mon, Sep 13, 2010 at 9:15 PM, Scott Duplichan <scott at notabs.org> wrote:
> ]-----Original Message-----
> ]From: coreboot-bounces+scott=notabs.org at coreboot.org [mailto:coreboot-]bounces+scott=notabs.org at coreboot.org] On Behalf Of Arne
> Georg Gleditsch
> ]Sent: Monday, September 13, 2010 03:51 AM
> ]To: Scott Duplichan
> ]Cc: 'Marc Jones'; coreboot at coreboot.org
> ]Subject: Re: [coreboot] AMD cache setup is broken
> ]
> ]"Scott Duplichan" <scott at notabs.org> writes:
> ]> I think it would be best to clear bit 35 of msr c001_102a in the AP
> ]> cores as well as the BSP core. Otherwise, the OS might see AP cores
> ]> having slightly lower performance than the BSP core. This bit affects
> ]> family 10h revC and newer (45 nm).
> ]
> ]Ok, so here's a patch adding this.  Clearing bit 35 is done
> ]unconditionally for all fam10 cpus, is that ok?  Setting is done based
> ]on processor type in defaults.h, as before.
>
> Thanks. This looks correct to me. I used simnow/tilapia to confirm bit
> 35 gets cleared in all cores. I found bit 35 never actually gets set.
> I submitted a patch to correct that. Once that patch is applied, I can
> see bit 35 gets set in all cores, then gets cleared in all cores.
>
> Thanks,
> Scott

Hi Scott,

Can you Acked-by: if this is working for you.

Marc



-- 
http://se-eng.com