[coreboot] [PATCH] Add support for Asus M4A785-M, with build instructions

[Myles Watson]

On Sat, Sep 11, 2010 at 3:47 PM, Juhana Helovuo <juhe at iki.fi> wrote:
> On Sat, 2010-09-11 at 23:36 +0300, Juhana Helovuo wrote:
>> On Sat, 2010-09-11 at 07:03 -0600, Myles Watson wrote:
>>
>> > So it works with my updated patch, but not with the uma & reserved
>> > patches?  Or does it not work at all?  Does it still work with your
>> > previous patch set?
>> >
>> > Could you send a full log with the last working version and the first
>> > broken version from this list?
>> >
>> > 1. Your original patches
>> > 2. 5799 + my board patch
>> > 3. 2 + uma.diff
>> > 4. 3 + reserved.diff
>> >
>> > uma.diff & reserved.diff should be independent, so you could try
>> > 2+reserved.diff also
>> >
>>
>> Ok, now I have some test results:
>>
>> * 5792 + my original patches --> boots ok
>> * 5792 + your simplified patches --> boots ok
>> * 5792 + your simplified patches + uma.diff --> boots ok (log attached)
>> * 5792 + your simplified patches + uma.diff + reserved.diff --> does not
>> build, patch seems to be for newer trunk version
>>
>> * 5799 + my original patches --> SATA failure (log attached)
>> * 5799 + your simplified patches --> SATA failure
>>
>> * 5802 + your simplified patch for 5800 --> SATA failure
>>
>> My conclusion from this is that something in the trunk has broken
>> between 5792 and 5799.
>
> Sorry about spamming the list, but I managed to test a few cases more:
>
> * 5795 + your simplified patches --> boots ok
> * 5795 + your simplified patches + uma.diff + reserved.diff --> boots ok
Thanks for tracking it down.  I committed the patches as
Rev 5805 (PCI & SB700)
Rev 5806 (Multiboot tables)
Rev 5807 (fam10 UMA)
Rev 5808 (fam10 reserved regions)
Rev 5809 (Asus M4A785-M)

> * 5796 + your simplified patches --> SATA failure
>
> It seems to me that the patches are ok, but some trunk change from 5795
> to 5796 is causing the problems.

There seems to be a problem with CONFIG_MMCONF_SUPPORT vs.
CONFIG_MMCONF_SUPPORT_DEFAULT.

This should work for you until it's fixed.  If it doesn't, I need to
dig a little deeper.

Index: src/northbridge/amd/amdfam10/Kconfig
===================================================================
--- src/northbridge/amd/amdfam10/Kconfig	(revision 5804)
+++ src/northbridge/amd/amdfam10/Kconfig	(working copy)
@@ -23,7 +23,6 @@
 	select HAVE_DEBUG_SMBUS
 	select HYPERTRANSPORT_PLUGIN_SUPPORT
 	select NORTHBRIDGE_AMD_AMDFAM10_ROOT_COMPLEX
-	select MMCONF_SUPPORT

 config AGP_APERTURE_SIZE
 	hex

Thanks,
Myles