[coreboot] [PATCH] timeout during PS/2 keyboard init

Marc Jones marcj303 at gmail.com
Wed Sep 8 22:16:49 CEST 2010


On Wed, Sep 8, 2010 at 1:11 PM, Scott Duplichan <scott at notabs.org> wrote:
> Thanks Marc. This patch avoids a timeout during PS/2 keyboard
> initialization. It can reduce KBC init time by up to 400 ms on
> real hardware, and by a minute or so on AMD simnow.
>
>
> Signed-off-by: Scott Duplichan <scott at notabs.org>
>
> Index: src/pc80/keyboard.c
> ===================================================================
> --- src/pc80/keyboard.c (revision 5788)
> +++ src/pc80/keyboard.c (working copy)
> @@ -242,7 +242,7 @@
>        outb(0x60, KBD_COMMAND);
>        if (!kbc_input_buffer_empty()) return;
>        outb(0x61, KBD_DATA);   /* send cmd: enable keyboard and IRQ 1 */
> -       if (kbc_output_buffer_full()) {
> +       if (kbc_input_buffer_empty()) {


I think you meant !kbc_input_buffer_empty()?


Marc

-- 
http://se-eng.com




More information about the coreboot mailing list