[coreboot] [patch] 6300ESB early smbus cleanup
stefan.reinauer at coresystems.de
Tue Oct 19 04:14:21 CEST 2010
On 18.10.2010, at 12:17, Peter Stuge <peter at stuge.se> wrote:
> Jonathan A. Kollasch wrote:
>> Remove unused variables from 6300ESB smbus_write_block().
>> #if 0 smbus_write_byte() and smbus_write_block() as they are
>> static and nothing uses them or are incompletely implemented.
> Why #if 0 rather than just removing the code completely? I think this
> is a piece of code which can already be found other places if a
> reference is needed?
Maybe use #ifdef DEADCODE if you want to leave it in. That will make it easier to recognize that the code was considered for dropping once before.
>> Signed-off-by: Jonathan Kollasch <jakllsch at kollasch.net>
> Acked-by: Peter Stuge <peter at stuge.se>
> coreboot mailing list: coreboot at coreboot.org
More information about the coreboot