[coreboot] [PATCH] Geode GX2 auto DRAM detect patch

[ron minnich]

On Fri, Oct 15, 2010 at 7:10 AM, Nils <njacobs8 at hetnet.nl> wrote:

> As i stated in the original message i tested the patch on my Geode GX2 Wyse
> S50 board.
> I didn`t test it on the Rumba and Frontrunner because i don`t have them and
> people who have them don`t seem to have time/interest to test.
> But i don`t think that is very imported because both boards are broken in the
> current state for years.

yes, you are completely right. And those rumba boards at least should
be removed. You've done very good work and I don't think you should
have to worry about  nonexistent boards. You are also right that GX2
was/is a mess and your cleanup is quite a huge improvement.

> I think the Rumba target was abandoned at that time in favor for the
> Frontrunner board that got committed.

They actually did work. But we did drop them once the real OLPC
hardware came along.

> The PLL setup code in the romstage.c files is nonfunctional because it is
> hardcoded in pll_rst.c to 366Mhz.
> The wrong PLL setup values that are still in Rumba and S50 (and were in Olpc)
> let the processor run on 100Mhz if enabled!

There are a lot of cases where settings that were "wrong" were the
only ones that worked. What can I say?

> So i think my patches are a big improvement and it is hard to "break" someones
> board with it.

Your patches are an enormous improvement. What I was trying to say is
that we should take your patches and remove boards that can not be
tested. We've got a lot of historical boards which nobody cares about,
so let's remove them.

> I am not planning to do a lot of little patches and abuild and boot test all
> of them separately as that cost me a lot of extra time.

No one is asking you to. My feeling is that if there is no one around
to test a 6-year-old board (rumba) then maybe it is time to remove it.

> I won`t bother you any longer.

Well, I'm sorry if that happens, because your changes are very good stuff.

ron