[coreboot] [PATCH] 780 mmconfig space access issue

Bao, Zheng Zheng.Bao at amd.com
Wed Oct 13 06:27:05 CEST 2010



I checked the code and found a stupid bug.
I wonder if it can fix your problem.

Signed-off-by: Zheng Bao <zheng.bao at amd.com>


Index: src/southbridge/amd/rs780/rs780_cmn.c
===================================================================
--- src/southbridge/amd/rs780/rs780_cmn.c (revision 5926)
+++ src/southbridge/amd/rs780/rs780_cmn.c (working copy)
@@ -70,7 +70,7 @@
      reg &= ~mask;
      reg |= val;
      if (reg != reg_old) {
-           *((u32 *) addr) = val;
+           *((u32 *) addr) = reg;
      }
 }
 
Index: src/southbridge/amd/rs690/rs690_cmn.c
===================================================================
--- src/southbridge/amd/rs690/rs690_cmn.c (revision 5926)
+++ src/southbridge/amd/rs690/rs690_cmn.c (working copy)
@@ -72,7 +72,7 @@
      reg &= ~mask;
      reg |= val;
      if (reg != reg_old) {
-           *((u32 *) addr) = val;
+           *((u32 *) addr) = reg;
      }
 }
 
Zheng
-------------- next part --------------
A non-text attachment was scrubbed...
Name: amd_RSxx0_pci_extension_access.patch
Type: application/octet-stream
Size: 722 bytes
Desc: amd_RSxx0_pci_extension_access.patch
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20101013/341ef5cd/attachment.obj>


More information about the coreboot mailing list