[coreboot] [PATCH] Split model_67x CPU support from model_6xx, with microcode / L2 cache code question

Keith Hui buurin at gmail.com
Wed Oct 13 05:41:24 CEST 2010

On Tue, Oct 12, 2010 at 7:23 PM, Uwe Hermann <uwe at hermann-uwe.de> wrote:
> Can you post an extra patch for splitting off CPUs to make it easier to
> review? The last one was merged into the already huge L2 patch which
> made it really hard to read.
And you shall receive, in small delicious pieces. :D

Attached patch adds support for Katmai Slot 1 CPUs (model_67x).
abuild-tested. Boot tested on P2B-LS.

Signed-off-by: Keith Hui <buurin at gmail.com>

Similar patch for Deschutes(65x) and Klamath (63x) to come, but I need
someone else to boot test them.

> After the split, your L2 patch should be relatively small and clean,
> please repost that too then.
As we already know the L2 patch is a huge chunk of code, so let's
figure out where best to place that code. It is specific to 63x,65x
and 67x CPUs. There are some small code path differences between these
CPU families. I'm trying to minimize duplication; if these code can be
put in one .c file and be linked from a few other places, that's how
I'd prefer it.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: model_67x.patch
Type: application/octet-stream
Size: 47339 bytes
Desc: not available
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20101012/9f08822d/attachment.obj>

More information about the coreboot mailing list