[coreboot] [PATCH] Remove various .c #includes from Intel 440BX/82371EB boards

Stefan Reinauer stefan.reinauer at coresystems.de
Sun Oct 10 02:26:38 CEST 2010

On 09.10.2010, at 03:04, Uwe Hermann <uwe at hermann-uwe.de> wrote:

> On Fri, Oct 08, 2010 at 02:41:40AM -0400, Corey Osgood wrote:
>> I think I've found the problem, include/console/console.h:
>> 62 #ifndef __ROMCC__
>> 63 void console_init(void);
>> 64 void post_code(u8 value);
>> 65 void __attribute__ ((noreturn)) die(const char *msg);
>> Maybe move that definition a few lines up, and see what happens? Or
> So far I couldn't find a combination which works, but it's not needed at
> the moment, I can dodge the problem by removing the die() calls
> alltogether, that was on my TODO list anyways. Those checks in the code
> are not really useful, the PCI device is always there, and we don't do
> such checks elsewhere in the code either.

Is that also true for newer qemus which emulate the q35 chipset? We should make sure coreboot runs nicely on those too.

> Updated patch attached, now survives abuild.
>> else converting the QEMU target to CAR seems like the other option.
> That won't work as far as I've heard (QEMU limitations).
> Uwe.
> -- 
> http://hermann-uwe.de     | http://sigrok.org
> http://randomprojects.org | http://unmaintained-free-software.org
> <v4_remove_c_includes_i82371eb_2.patch>
> -- 
> coreboot mailing list: coreboot at coreboot.org
> http://www.coreboot.org/mailman/listinfo/coreboot

More information about the coreboot mailing list