[coreboot] [PATCH try 4] Reduce duplicate definition in CAR code.

Stefan Reinauer stefan.reinauer at coresystems.de
Thu Oct 7 18:16:28 CEST 2010

 On 10/7/10 5:58 AM, Kevin O'Connor wrote:
> BTW, the list concept doesn't make much sense anyway - at least on
> Via, there is no need to clear the fixed mtrrs, and you don't need a
> list to clear the variable mtrrs (a simple iterator would suffice).
The list seemed more comprehensible than writing down linear code. It's
simple for the variable mtrrs, but the fixed ones are not linearly spread.

Why do you assume it's not needed to clear the fixed MTRRs on VIA
systems? I don't think we should assume they didn't get set to "bad"
values by the OS running prior to a reset, for example.


More information about the coreboot mailing list