[coreboot] [PATCH] Drop unneeded header from i82371eb_enable_rom.c

Uwe Hermann uwe at hermann-uwe.de
Sat Oct 2 14:43:04 CEST 2010

On Fri, Oct 01, 2010 at 12:31:47AM -0400, Keith Hui wrote:
> A "I am alive" ping kind of patch while I continue to figure out ACPI
> for 440BX boards among other things.
> Drops <stdint.h> from the file. My coreboot still compiles fine
> without it. abuild tested.
> Signed-off-by: Keith Hui <buurin at gmail.com>

Hm, not sure about this one. The file _does_ use stuff from stdint.h
directly, so technically having the #include is correct. On the other
hand, that .c file is included itself from romstage.c usually and
that file already #includes stdint.h (directly or indirectly itself).

Note that we're currently trying to move away from including .c files
directly, as soon as that is done and the files are compiled separately
the #include may very well be required then (well, I think).

http://hermann-uwe.de     | http://sigrok.org
http://randomprojects.org | http://unmaintained-free-software.org

More information about the coreboot mailing list