[coreboot] [PATCH] Factor out common CAR asm snippets

Stefan Reinauer stefan.reinauer at coresystems.de
Sat Oct 2 00:09:31 CEST 2010


 On 10/1/10 11:27 PM, Uwe Hermann wrote:
> See patch.
>
> abuilt-tested.
>
>
> Uwe.
IMHO the patch makes it really hard to actually see what the code does.
I think Idwer was recently running into a problem where the use of
post_code would trash %eax were hard to comprehend. Now we seem have a
lot more code that comes from somewhere else and touches registers
without it being obvious to the reader of the code.

Just my 2ct.

Stefan




More information about the coreboot mailing list