[coreboot] [commit] r6125 - trunk/src/southbridge/amd/sb600

Fri Nov 26 23:39:44 CET 2010

Author: uwe
Date: Fri Nov 26 23:39:40 2010
New Revision: 6125
URL: https://tracker.coreboot.org/trac/coreboot/changeset/6125

Log:
AMD SB600: Add TINY_BOOTBLOCK support.

Signed-off-by: Uwe Hermann <uwe at hermann-uwe.de>
Acked-by: Patrick Georgi <patrick at georgi-clan.de>

Added:
   trunk/src/southbridge/amd/sb600/bootblock.c
   trunk/src/southbridge/amd/sb600/sb600_enable_rom.c
Modified:
   trunk/src/southbridge/amd/sb600/Kconfig
   trunk/src/southbridge/amd/sb600/sb600_early_setup.c

Modified: trunk/src/southbridge/amd/sb600/Kconfig
==============================================================================

--- trunk/src/southbridge/amd/sb600/Kconfig	Fri Nov 26 23:35:11 2010	(r6124)
+++ trunk/src/southbridge/amd/sb600/Kconfig	Fri Nov 26 23:39:40 2010	(r6125)
@@ -21,6 +21,7 @@
 	bool
 	select IOAPIC
 	select HAVE_USBDEBUG
+	select TINY_BOOTBLOCK
 
 config EHCI_BAR
 	hex

Added: trunk/src/southbridge/amd/sb600/bootblock.c
==============================================================================
--- /dev/null	00:00:00 1970	(empty, because file is newly added)
+++ trunk/src/southbridge/amd/sb600/bootblock.c	Fri Nov 26 23:39:40 2010	(r6125)
@@ -0,0 +1,26 @@
+/*
+ * This file is part of the coreboot project.
+ *
+ * Copyright (C) 2010 Uwe Hermann <uwe at hermann-uwe.de>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301 USA
+ */
+
+#include "southbridge/amd/sb600/sb600_enable_rom.c"
+
+static void bootblock_southbridge_init(void)
+{
+	sb600_enable_rom();
+}

Modified: trunk/src/southbridge/amd/sb600/sb600_early_setup.c
==============================================================================
--- trunk/src/southbridge/amd/sb600/sb600_early_setup.c	Fri Nov 26 23:35:11 2010	(r6124)
+++ trunk/src/southbridge/amd/sb600/sb600_early_setup.c	Fri Nov 26 23:39:40 2010	(r6125)
@@ -56,11 +56,9 @@
 *	Serial port 0
 *	KBC Port
 *	ACPI Micro-controller port
-*	LPC ROM size
 *	This function does not change port 0x80 decoding.
 *	Console output through any port besides 0x3f8 is unsupported.
 *	If you use FWH ROMs, you have to setup IDSEL.
-* NOTE: Call me ASAP, because I will reset LPC ROM size!
 * Reviewed-by: Carl-Daniel Hailfinger
 * Reviewed against AMD SB600 Register Reference Manual rev. 3.03, section 3.1
 * 	(LPC ISA Bridge)
@@ -97,27 +95,13 @@
 	reg8 |= (1 << 5) | (1 << 6);
 	pci_write_config8(dev, 0x47, reg8);
 
-	/* SuperIO, LPC ROM */
+	/* Super I/O, RTC */
 	reg8 = pci_read_config8(dev, 0x48);
 	/* Decode ports 0x2e-0x2f, 0x4e-0x4f (SuperI/O configuration) */
 	reg8 |= (1 << 1) | (1 << 0);
-	/* Decode variable LPC ROM address ranges 1&2 (see register 0x68-0x6b, 0x6c-0x6f) */
-	reg8 |= (1 << 3) | (1 << 4);
 	/* Decode port 0x70-0x73 (RTC) */
-	reg8 |= 1 << 6;
+	reg8 |= (1 << 6);
 	pci_write_config8(dev, 0x48, reg8);
-
-	/* hardware should enable LPC ROM by pin straps */
-	/* ROM access at 0xFFF80000/0xFFF00000 - 0xFFFFFFFF */
-	/* See detail in BDG-215SB600-03.pdf page 15. */
-	/* enable LPC ROM range mirroring start 0x000e(0000) */
-	pci_write_config16(dev, 0x68, 0x000e);
-	/* enable LPC ROM range mirroring end   0x000f(ffff) */
-	pci_write_config16(dev, 0x6a, 0x000f);
-	/* enable LPC ROM range start, 0xfff8(0000): 512KB, 0xfff0(0000): 1MB, 0xffe0(0000): 2MB, 0xffc0(0000): 4MB */
-	pci_write_config16(dev, 0x6c, 0xffc0);
-	/* enable LPC ROM range end at 0xffff(ffff) */
-	pci_write_config16(dev, 0x6e, 0xffff);
 }
 
 /* what is its usage? */
@@ -387,13 +371,12 @@
 	pci_write_config8(dev, 0x46, 0xC3);
 	pci_write_config8(dev, 0x47, 0xFF);
 
+	// TODO: This has already been done(?)
 	/* IO/Mem Port Decode Enable, I don't know why CIM disable some ports.
 	 *  Disable LPC TimeOut counter, enable SuperIO Configuration Port (2e/2f),
-	 * Alternate SuperIO Configuration Port (4e/4f), Wide Generic IO Port (64/65).
-	 * Enable bits for LPC ROM memory address range 1&2 for 1M ROM setting.*/
+	 * Alternate SuperIO Configuration Port (4e/4f), Wide Generic IO Port (64/65). */
 	byte = pci_read_config8(dev, 0x48);
 	byte |= (1 << 1) | (1 << 0);	/* enable Super IO config port 2e-2h, 4e-4f */
-	byte |= (1 << 3) | (1 << 4);	/* enable for LPC ROM address range1&2, Enable 512KB rom access at 0xFFF80000 - 0xFFFFFFFF */
 	byte |= 1 << 6;		/* enable for RTC I/O range */
 	pci_write_config8(dev, 0x48, byte);
 	pci_write_config8(dev, 0x49, 0xFF);
@@ -402,12 +385,6 @@
 	byte |= ((1 << 1) + (1 << 6));	/*0x42, save the configuraion for port 0x80. */
 	pci_write_config8(dev, 0x4A, byte);
 
-	/* Set LPC ROM size, it has been done in sb600_lpc_init().
-	 * enable LPC ROM range, 0xfff8: 512KB, 0xfff0: 1MB;
-	 * enable LPC ROM range, 0xfff8: 512KB, 0xfff0: 1MB
-	 * pci_write_config16(dev, 0x68, 0x000e)
-	 * pci_write_config16(dev, 0x6c, 0xfff0);*/
-
 	/* Enable Tpm12_en and Tpm_legacy. I don't know what is its usage and copied from CIM. */
 	pci_write_config8(dev, 0x7C, 0x05);
 

Added: trunk/src/southbridge/amd/sb600/sb600_enable_rom.c
==============================================================================
--- /dev/null	00:00:00 1970	(empty, because file is newly added)
+++ trunk/src/southbridge/amd/sb600/sb600_enable_rom.c	Fri Nov 26 23:39:40 2010	(r6125)
@@ -0,0 +1,65 @@
+/*
+ * This file is part of the coreboot project.
+ *
+ * Copyright (C) 2008 Advanced Micro Devices, Inc.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; version 2 of the License.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301 USA
+ */
+
+#include <stdint.h>
+#include <arch/io.h>
+#include <arch/romcc_io.h>
+#include <device/pci_ids.h>
+
+/*
+ * Enable 4MB (LPC) ROM access at 0xFFC00000 - 0xFFFFFFFF.
+ *
+ * Hardware should enable LPC ROM by pin straps. This function does not
+ * handle the theoretically possible PCI ROM, FWH, or SPI ROM configurations.
+ *
+ * The SB600 power-on default is to map 256K ROM space.
+ *
+ * Details: AMD SB600 BIOS Developer's Guide (BDG), page 15.
+ */
+static void sb600_enable_rom(void)
+{
+	u8 reg8;
+	device_t dev;
+
+	dev = pci_locate_device(PCI_ID(PCI_VENDOR_ID_ATI,
+				       PCI_DEVICE_ID_ATI_SB600_LPC), 0);
+
+	/* Decode variable LPC ROM address ranges 1 and 2. */
+	reg8 = pci_read_config8(dev, 0x48);
+	reg8 |= (1 << 3) | (1 << 4);
+	pci_write_config8(dev, 0x48, reg8);
+
+	/* LPC ROM address range 1: */
+	/* Enable LPC ROM range mirroring start at 0x000e(0000). */
+	pci_write_config16(dev, 0x68, 0x000e);
+	/* Enable LPC ROM range mirroring end at 0x000f(ffff). */
+	pci_write_config16(dev, 0x6a, 0x000f);
+
+	/* LPC ROM address range 2: */
+	/*
+	 * Enable LPC ROM range start at:
+	 * 0xfff8(0000): 512KB
+	 * 0xfff0(0000): 1MB
+	 * 0xffe0(0000): 2MB
+	 * 0xffc0(0000): 4MB
+	 */
+	pci_write_config16(dev, 0x6c, 0xffc0); /* 4 MB */
+	/* Enable LPC ROM range end at 0xffff(ffff). */
+	pci_write_config16(dev, 0x6e, 0xffff);
+}


