[coreboot] [commit] r6095 - in trunk/src: mainboard/amd/mahogany_fam10 mainboard/amd/norwich mainboard/amd/tilapia_fam10 mainboard/asus/m4a785-m mainboard/iei/kino-780am2-fam10 mainboard/intel/xe7501devkit ma...

repository service svn at coreboot.org
Thu Nov 18 21:12:14 CET 2010


Author: uwe
Date: Thu Nov 18 21:12:13 2010
New Revision: 6095
URL: https://tracker.coreboot.org/trac/coreboot/changeset/6095

Log:
Fix/drop some obsolete comments,

 - s/Options.lb/devicetree.cb/
 
 - s/Config.lb/devicetree.cb/

 - s/cache_as_ram_auto.c/romstage.c/
 
 - h8dmr_fam10/README: Drop obsolete comment, we have mc_patch_01000086.h in
   the tree now.
 
Signed-off-by: Uwe Hermann <uwe at hermann-uwe.de>
Acked-by: Uwe Hermann <uwe at hermann-uwe.de>

Modified:
   trunk/src/mainboard/amd/mahogany_fam10/spd_addr.h
   trunk/src/mainboard/amd/norwich/romstage.c
   trunk/src/mainboard/amd/tilapia_fam10/spd_addr.h
   trunk/src/mainboard/asus/m4a785-m/spd_addr.h
   trunk/src/mainboard/iei/kino-780am2-fam10/spd_addr.h
   trunk/src/mainboard/intel/xe7501devkit/acpi_tables.c
   trunk/src/mainboard/intel/xe7501devkit/mptable.c
   trunk/src/mainboard/supermicro/h8dmr_fam10/README
   trunk/src/mainboard/traverse/geos/romstage.c
   trunk/src/mainboard/via/epia-m700/acpi_tables.c
   trunk/src/mainboard/via/epia-n/acpi_tables.c
   trunk/src/northbridge/amd/amdk8/northbridge.c
   trunk/src/northbridge/amd/lx/grphinit.c
   trunk/src/northbridge/intel/i945/early_init.c
   trunk/src/southbridge/intel/i82801ax/i82801ax_lpc.c
   trunk/src/southbridge/intel/i82801bx/i82801bx_lpc.c
   trunk/src/southbridge/intel/i82801gx/i82801gx_ide.c
   trunk/src/southbridge/intel/i82801gx/i82801gx_sata.c
   trunk/src/southbridge/intel/i82870/p64h2_ioapic.c

Modified: trunk/src/mainboard/amd/mahogany_fam10/spd_addr.h
==============================================================================
--- trunk/src/mainboard/amd/mahogany_fam10/spd_addr.h	Thu Nov 18 20:40:33 2010	(r6094)
+++ trunk/src/mainboard/amd/mahogany_fam10/spd_addr.h	Thu Nov 18 21:12:13 2010	(r6095)
@@ -19,7 +19,7 @@
 
 /**
  * This file defines the SPD addresses for the mainboard. Must be included in
- * cache_as_ram_auto.c
+ * romstage.c
  */
 
 #define RC00 0

Modified: trunk/src/mainboard/amd/norwich/romstage.c
==============================================================================
--- trunk/src/mainboard/amd/norwich/romstage.c	Thu Nov 18 20:40:33 2010	(r6094)
+++ trunk/src/mainboard/amd/norwich/romstage.c	Thu Nov 18 21:12:13 2010	(r6095)
@@ -77,7 +77,7 @@
 	/* cs5536_disable_internal_uart: disable them for now, set them
 	 * up later...
 	 */
-	/* If debug. real setup done in chipset init via Config.lb. */
+	/* If debug. real setup done in chipset init via devicetree.cb. */
 	cs5536_setup_onchipuart(1);
 	mb_gpio_init();
 	uart_init();

Modified: trunk/src/mainboard/amd/tilapia_fam10/spd_addr.h
==============================================================================
--- trunk/src/mainboard/amd/tilapia_fam10/spd_addr.h	Thu Nov 18 20:40:33 2010	(r6094)
+++ trunk/src/mainboard/amd/tilapia_fam10/spd_addr.h	Thu Nov 18 21:12:13 2010	(r6095)
@@ -19,7 +19,7 @@
 
 /**
  * This file defines the SPD addresses for the mainboard. Must be included in
- * cache_as_ram_auto.c
+ * romstage.c
  */
 
 #define RC00 0

Modified: trunk/src/mainboard/asus/m4a785-m/spd_addr.h
==============================================================================
--- trunk/src/mainboard/asus/m4a785-m/spd_addr.h	Thu Nov 18 20:40:33 2010	(r6094)
+++ trunk/src/mainboard/asus/m4a785-m/spd_addr.h	Thu Nov 18 21:12:13 2010	(r6095)
@@ -19,7 +19,7 @@
 
 /**
  * This file defines the SPD addresses for the mainboard. Must be included in
- * cache_as_ram_auto.c
+ * romstage.c
  */
 
 #define RC00 0

Modified: trunk/src/mainboard/iei/kino-780am2-fam10/spd_addr.h
==============================================================================
--- trunk/src/mainboard/iei/kino-780am2-fam10/spd_addr.h	Thu Nov 18 20:40:33 2010	(r6094)
+++ trunk/src/mainboard/iei/kino-780am2-fam10/spd_addr.h	Thu Nov 18 21:12:13 2010	(r6095)
@@ -19,7 +19,7 @@
 
 /**
  * This file defines the SPD addresses for the mainboard. Must be included in
- * cache_as_ram_auto.c
+ * romstage.c
  */
 
 #define RC00 0

Modified: trunk/src/mainboard/intel/xe7501devkit/acpi_tables.c
==============================================================================
--- trunk/src/mainboard/intel/xe7501devkit/acpi_tables.c	Thu Nov 18 20:40:33 2010	(r6094)
+++ trunk/src/mainboard/intel/xe7501devkit/acpi_tables.c	Thu Nov 18 21:12:13 2010	(r6095)
@@ -55,7 +55,7 @@
 	// P64H2#2 Bus A IOAPIC
 	dev = dev_find_slot(PCI_BUS_E7501_HI_B, PCI_DEVFN(30, 0));
 	if (!dev)
-		BUG();		// Config.lb error?
+		BUG();
 	res = find_resource(dev, PCI_BASE_ADDRESS_0);
 	current += acpi_create_madt_ioapic((acpi_madt_ioapic_t *)current, IOAPIC_P64H2_2_BUS_A, res->base, irq_start);
 	irq_start += INTEL_IOAPIC_NUM_INTERRUPTS;
@@ -63,7 +63,7 @@
 	// P64H2#2 Bus B IOAPIC
 	dev = dev_find_slot(PCI_BUS_E7501_HI_B, PCI_DEVFN(28, 0));
 	if (!dev)
-		BUG();		// Config.lb error?
+		BUG();
 	res = find_resource(dev, PCI_BASE_ADDRESS_0);
 	current += acpi_create_madt_ioapic((acpi_madt_ioapic_t *)current, IOAPIC_P64H2_2_BUS_B, res->base, irq_start);
 	irq_start += INTEL_IOAPIC_NUM_INTERRUPTS;
@@ -72,7 +72,7 @@
 	// P64H2#1 Bus A IOAPIC
 	dev = dev_find_slot(PCI_BUS_E7501_HI_D, PCI_DEVFN(30, 0));
 	if (!dev)
-		BUG();		// Config.lb error?
+		BUG();
 	res = find_resource(dev, PCI_BASE_ADDRESS_0);
 	current += acpi_create_madt_ioapic((acpi_madt_ioapic_t *)current, IOAPIC_P64H2_1_BUS_A, res->base, irq_start);
 	irq_start += INTEL_IOAPIC_NUM_INTERRUPTS;
@@ -80,7 +80,7 @@
 	// P64H2#1 Bus B IOAPIC
 	dev = dev_find_slot(PCI_BUS_E7501_HI_D, PCI_DEVFN(28, 0));
 	if (!dev)
-		BUG();		// Config.lb error?
+		BUG();
 	res = find_resource(dev, PCI_BASE_ADDRESS_0);
 	current += acpi_create_madt_ioapic((acpi_madt_ioapic_t *)current, IOAPIC_P64H2_1_BUS_B, res->base, irq_start);
 	irq_start += INTEL_IOAPIC_NUM_INTERRUPTS;

Modified: trunk/src/mainboard/intel/xe7501devkit/mptable.c
==============================================================================
--- trunk/src/mainboard/intel/xe7501devkit/mptable.c	Thu Nov 18 20:40:33 2010	(r6094)
+++ trunk/src/mainboard/intel/xe7501devkit/mptable.c	Thu Nov 18 21:12:13 2010	(r6095)
@@ -42,14 +42,14 @@
 	// P64H2#2 Bus A IOAPIC
 	dev = dev_find_slot(PCI_BUS_E7501_HI_B, PCI_DEVFN(30, 0));
 	if (!dev)
-		BUG();		// Config.lb error?
+		BUG();
 	res = find_resource(dev, PCI_BASE_ADDRESS_0);
 	smp_write_ioapic(mc, IOAPIC_P64H2_2_BUS_A, P64H2_IOAPIC_VERSION, res->base);
 
 	// P64H2#2 Bus B IOAPIC
 	dev = dev_find_slot(PCI_BUS_E7501_HI_B, PCI_DEVFN(28, 0));
 	if (!dev)
-		BUG();		// Config.lb error?
+		BUG();
 	res = find_resource(dev, PCI_BASE_ADDRESS_0);
 	smp_write_ioapic(mc, IOAPIC_P64H2_2_BUS_B, P64H2_IOAPIC_VERSION, res->base);
 
@@ -57,14 +57,14 @@
 	// P64H2#1 Bus A IOAPIC
 	dev = dev_find_slot(PCI_BUS_E7501_HI_D, PCI_DEVFN(30, 0));
 	if (!dev)
-		BUG();		// Config.lb error?
+		BUG();
 	res = find_resource(dev, PCI_BASE_ADDRESS_0);
 	smp_write_ioapic(mc, IOAPIC_P64H2_1_BUS_A, P64H2_IOAPIC_VERSION, res->base);
 
 	// P64H2#1 Bus B IOAPIC
 	dev = dev_find_slot(PCI_BUS_E7501_HI_D, PCI_DEVFN(28, 0));
 	if (!dev)
-		BUG();		// Config.lb error?
+		BUG();
 	res = find_resource(dev, PCI_BASE_ADDRESS_0);
 	smp_write_ioapic(mc, IOAPIC_P64H2_1_BUS_B, P64H2_IOAPIC_VERSION, res->base);
 }

Modified: trunk/src/mainboard/supermicro/h8dmr_fam10/README
==============================================================================
--- trunk/src/mainboard/supermicro/h8dmr_fam10/README	Thu Nov 18 20:40:33 2010	(r6094)
+++ trunk/src/mainboard/supermicro/h8dmr_fam10/README	Thu Nov 18 21:12:13 2010	(r6095)
@@ -2,10 +2,6 @@
 
 There are a number of outstanding issues:
 
-* we don't have the mc_patch_01000086.h CPU ucode file yet which is
-referenced in a comment in src/mainboard/supermicro/h8dmr_fam10/Options.lb.
-AMD has not released it yet. This is not a problem specific to this port.
-
 * I'm seeing toolchain issues. I can't get this tree to compile correctly with
 gcc 4.3 (32 bit) - there is an optimization issue where certain parts of the
 CBFS code execute very slowly. With gcc 3.4 (32 bit) that slowness

Modified: trunk/src/mainboard/traverse/geos/romstage.c
==============================================================================
--- trunk/src/mainboard/traverse/geos/romstage.c	Thu Nov 18 20:40:33 2010	(r6094)
+++ trunk/src/mainboard/traverse/geos/romstage.c	Thu Nov 18 21:12:13 2010	(r6095)
@@ -78,7 +78,7 @@
 	/* cs5536_disable_internal_uart: disable them for now, set them
 	 * up later...
 	 */
-	/* If debug. real setup done in chipset init via Config.lb. */
+	/* If debug. real setup done in chipset init via devicetree.cb. */
 	cs5536_setup_onchipuart(1);
 	mb_gpio_init();
 	uart_init();

Modified: trunk/src/mainboard/via/epia-m700/acpi_tables.c
==============================================================================
--- trunk/src/mainboard/via/epia-m700/acpi_tables.c	Thu Nov 18 20:40:33 2010	(r6094)
+++ trunk/src/mainboard/via/epia-m700/acpi_tables.c	Thu Nov 18 21:12:13 2010	(r6095)
@@ -42,9 +42,9 @@
 
 /*
  * These four macros are copied from <arch/smp/mpspec.h>, I have to do this
- * since the "default CONFIG_GENERATE_MP_TABLE = 0" in Options.lb, and also since
+ * since the "CONFIG_GENERATE_MP_TABLE = 0", and also since
  * mainboard/via/... have no mptable.c (so that I can not set
- * CONFIG_GENERATE_MP_TABLE = 1) as many other mainboards.
+ * "CONFIG_GENERATE_MP_TABLE = 1" as many other mainboards.
  * So I have to copy these four to here. acpi_fill_madt() needs this.
  */
 #define MP_IRQ_POLARITY_HIGH	0x1

Modified: trunk/src/mainboard/via/epia-n/acpi_tables.c
==============================================================================
--- trunk/src/mainboard/via/epia-n/acpi_tables.c	Thu Nov 18 20:40:33 2010	(r6094)
+++ trunk/src/mainboard/via/epia-n/acpi_tables.c	Thu Nov 18 21:12:13 2010	(r6095)
@@ -39,10 +39,10 @@
 extern const unsigned char AmlCode[];
 
 /*
- * These four macros are copied from <arch/smp/mpspec.h>, I have to do this
- * since the "default CONFIG_GENERATE_MP_TABLE = 0" in Options.lb, and also since
+ * These 8 macros are copied from <arch/smp/mpspec.h>, I have to do this
+ * since the "CONFIG_GENERATE_MP_TABLE = 0", and also since
  * mainboard/via/... have no mptable.c (so that I can not set
- * CONFIG_GENERATE_MP_TABLE = 1) as many other mainboards.
+ * "CONFIG_GENERATE_MP_TABLE = 1" as many other mainboards.
  * So I have to copy these four to here. acpi_fill_madt() needs this.
  */
 #define MP_IRQ_POLARITY_DEFAULT	0x0

Modified: trunk/src/northbridge/amd/amdk8/northbridge.c
==============================================================================
--- trunk/src/northbridge/amd/amdk8/northbridge.c	Thu Nov 18 20:40:33 2010	(r6094)
+++ trunk/src/northbridge/amd/amdk8/northbridge.c	Thu Nov 18 21:12:13 2010	(r6095)
@@ -1,6 +1,6 @@
 /* This should be done by Eric
 	2004.12 yhlu add dual core support
-	2005.01 yhlu add support move apic before pci_domain in MB Config.lb
+	2005.01 yhlu add support move apic before pci_domain in MB devicetree.cb
 	2005.02 yhlu add e0 memory hole support
 	2005.11 yhlu add put sb ht chain on bus 0
 */

Modified: trunk/src/northbridge/amd/lx/grphinit.c
==============================================================================
--- trunk/src/northbridge/amd/lx/grphinit.c	Thu Nov 18 20:40:33 2010	(r6094)
+++ trunk/src/northbridge/amd/lx/grphinit.c	Thu Nov 18 21:12:13 2010	(r6095)
@@ -85,7 +85,7 @@
 	 * Controller Priority Select(11)                       1, Primary
 	 * Display Select(10:8)                                         0x0, CRT
 	 * Graphics Memory Size(7:1)                            CONFIG_VIDEO_MB >> 1,
-	 *                                                                                      defined in mainboard/../Options.lb
+	 *                                                                                      defined in devicetree.cb
 	 * PLL Reference Clock Bypass(0)                        0, Default
 	 */
 

Modified: trunk/src/northbridge/intel/i945/early_init.c
==============================================================================
--- trunk/src/northbridge/intel/i945/early_init.c	Thu Nov 18 20:40:33 2010	(r6094)
+++ trunk/src/northbridge/intel/i945/early_init.c	Thu Nov 18 21:12:13 2010	(r6095)
@@ -570,7 +570,7 @@
 
 	/* Setup SLOTCAP */
 	/* TODO: These values are mainboard dependent and should
-	 * be set from Config.lb or Options.lb.
+	 * be set from devicetree.cb.
 	 */
 	/* NOTE: SLOTCAP becomes RO after the first write! */
 	reg32 = pcie_read_config32(PCI_DEV(0, 0x01, 0), 0xb4);

Modified: trunk/src/southbridge/intel/i82801ax/i82801ax_lpc.c
==============================================================================
--- trunk/src/southbridge/intel/i82801ax/i82801ax_lpc.c	Thu Nov 18 20:40:33 2010	(r6094)
+++ trunk/src/southbridge/intel/i82801ax/i82801ax_lpc.c	Thu Nov 18 21:12:13 2010	(r6095)
@@ -68,7 +68,7 @@
 /*
  * Use 0x0ef8 for a bitmap to cover all these IRQ's.
  * Use the defined IRQ values above or set mainboard
- * specific IRQ values in your mainboards Config.lb.
+ * specific IRQ values in your devicetree.cb.
  */
 static void i82801ax_enable_apic(struct device *dev)
 {

Modified: trunk/src/southbridge/intel/i82801bx/i82801bx_lpc.c
==============================================================================
--- trunk/src/southbridge/intel/i82801bx/i82801bx_lpc.c	Thu Nov 18 20:40:33 2010	(r6094)
+++ trunk/src/southbridge/intel/i82801bx/i82801bx_lpc.c	Thu Nov 18 21:12:13 2010	(r6095)
@@ -70,7 +70,7 @@
 /*
  * Use 0x0ef8 for a bitmap to cover all these IRQ's.
  * Use the defined IRQ values above or set mainboard
- * specific IRQ values in your mainboards Config.lb.
+ * specific IRQ values in your devicetree.cb.
 */
 static void i82801bx_enable_apic(struct device *dev)
 {

Modified: trunk/src/southbridge/intel/i82801gx/i82801gx_ide.c
==============================================================================
--- trunk/src/southbridge/intel/i82801gx/i82801gx_ide.c	Thu Nov 18 20:40:33 2010	(r6094)
+++ trunk/src/southbridge/intel/i82801gx/i82801gx_ide.c	Thu Nov 18 21:12:13 2010	(r6095)
@@ -37,7 +37,7 @@
 
 	printk(BIOS_DEBUG, "i82801gx_ide: initializing... ");
 	if (config == NULL) {
-		printk(BIOS_ERR, "\ni82801gx_ide: Not mentioned in mainboard's Config.lb!\n");
+		printk(BIOS_ERR, "\ni82801gx_ide: Not mentioned in devicetree.cb!\n");
 		// Trying to set somewhat safe defaults instead of bailing out.
 		enable_primary = enable_secondary = 1;
 	} else {

Modified: trunk/src/southbridge/intel/i82801gx/i82801gx_sata.c
==============================================================================
--- trunk/src/southbridge/intel/i82801gx/i82801gx_sata.c	Thu Nov 18 20:40:33 2010	(r6094)
+++ trunk/src/southbridge/intel/i82801gx/i82801gx_sata.c	Thu Nov 18 21:12:13 2010	(r6095)
@@ -36,7 +36,7 @@
 	printk(BIOS_DEBUG, "i82801gx_sata: initializing...\n");
 
 	if (config == NULL) {
-		printk(BIOS_ERR, "i82801gx_sata: error: device not in Config.lb!\n");
+		printk(BIOS_ERR, "i82801gx_sata: error: device not in devicetree.cb!\n");
 		return;
 	}
 

Modified: trunk/src/southbridge/intel/i82870/p64h2_ioapic.c
==============================================================================
--- trunk/src/southbridge/intel/i82870/p64h2_ioapic.c	Thu Nov 18 20:40:33 2010	(r6094)
+++ trunk/src/southbridge/intel/i82870/p64h2_ioapic.c	Thu Nov 18 21:12:13 2010	(r6095)
@@ -40,10 +40,10 @@
 
     // A note on IOAPIC addresses:
     //  0 and 1 are used for the local APICs of the dual virtual
-	//	(hyper-threaded) CPUs of physical CPU 0 (mainboard/Config.lb).
+    //  (hyper-threaded) CPUs of physical CPU 0 (devicetree.cb).
     //  6 and 7 are used for the local APICs of the dual virtual
-	//	(hyper-threaded) CPUs of physical CPU 1 (mainboard/Config.lb).
-    //  2 is used for the IOAPIC in the 82801 Southbridge (hard-coded in i82801xx_lpc.c)
+    //  (hyper-threaded) CPUs of physical CPU 1 (devicetree.cb).
+    //  2 is used for the IOAPIC in the 82801 southbridge (hard-coded in i82801xx_lpc.c)
 
     // Map APIC index into APIC ID
     // IDs 3, 4, 5, and 8+ are available (see above note)




More information about the coreboot mailing list