[coreboot] [PATCH] Drop W83627THF, it's the same device as W83627THG
uwe at hermann-uwe.de
Tue Nov 16 23:28:14 CET 2010
On Tue, Nov 16, 2010 at 10:05:47PM +0100, Stefan Reinauer wrote:
> * Uwe Hermann <uwe at hermann-uwe.de> [101116 21:46]:
> > On Tue, Nov 16, 2010 at 12:06:23PM -0800, Stefan Reinauer wrote:
> > > Should we rename the part to w83627 then?
> > That's too generic, many other Winbond Super I/Os start with that prefix:
> > w83627dhg
> > w83627ehg
> > w83627hf
> > w83627thf
> > w83627thg
> > w83627uhg
> > (and probably some others)
> How different are they? Is there any knowlegde about what the letters
> mean? ie. do dhg, ehg and hf share some "h" feature while thf and thg
> share "t"? Or is it more or less random, or even big internal changes
> like for the ICH southbridges?
I'd say more or less random. Only the F/G suffix usually means Pb-free
or not, the rest doesn't directly translate to "similar enough" I think.
Now, it would be possible to do one common driver for multiple (probably
not all, but many) Winbond Super I/Os, see smscsuperio for an
(admittedly incomplete and a bit convoluted) example, but I had a feeling
you normally do not like such unified drivers all that much ;)
I'd like to drop the definately useless W83627THF first though, if there is
enough interest I can also try to do a more unified driver later.
> > We could do w83627th, or w83627thf_g or so, but I guess it's also fine
> > to just keep one of the two names.
> I don't particularly like the underscore, but w83627th sounds good.
OK, I'll make another patch to rename _all_ superios which have
multiple irrelevant suffixes accordingly.
> > I'll post a follow-up patch which
> > adds code comments like "This code supports W83627THF/THG" etc. to
> > all Super I/Os anyway to document this a bit better.
> Please remember to add the change to our Flag Days page:
Yup, will do after the commit.
http://hermann-uwe.de | http://sigrok.org
http://randomprojects.org | http://unmaintained-free-software.org
More information about the coreboot