[coreboot] [PATCH] Debugging facility improvements

[Uwe Hermann]

On Tue, Oct 26, 2010 at 07:19:59AM +0200, Peter Stuge wrote:
> > > Should this also force debug level to SPEW?
> > 
> > No idea, but it's unrelated to this patch.
> 
> I disagree.

We agree to disagree :)


> > As far as I can see all other such DEBUG_* mechanisms don't force
> > the debug level to SPEW either, so if we want to do that (I'm not
> > sure we do) that's material for another patch.
> 
> My point is that the patch claims to improve debugging, but in fact
> it adds the possibility that a user creates a configuration where
> they expect malloc debug messages but in fact do not get any because
> there is a glitch in Kconfig between the option they enabled and the
> requirement in code for SPEW loglevel for that option to have any
> effect. I don't think we should accept glitches like that, it is
> potentially a huge waste of time for the user, as well as extremely
> annoying. It makes coreboot look really unprofessional. :\

Yep. Updated patch as discussed on IRC. We only show the various DEBUG
options if at least DEBUG or SPEW was selected as loglevel in
menuconfig, as otherwise the additional debug code would not be printed
anyway.


Uwe.
-- 
http://hermann-uwe.de     | http://sigrok.org
http://randomprojects.org | http://unmaintained-free-software.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: v4_malloc_debug_2.patch
Type: text/x-diff
Size: 3955 bytes
Desc: not available
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20101110/2d51fd58/attachment.bin>