[coreboot] [commit] r6048 - trunk/src/southbridge/nvidia/mcp55

repository service svn at coreboot.org
Mon Nov 8 18:41:44 CET 2010


Author: ward
Date: Mon Nov  8 18:41:43 2010
New Revision: 6048
URL: https://tracker.coreboot.org/trac/coreboot/changeset/6048

Log:
We can't print this early.

This patch fixes a hang on

  supermicro/h8dme
  supermicro/h8dmr
  supermicro/h8dmr_fam10

and possibly on other mcp55-based boards.

Signed-off-by: Ward Vandewege <ward at gnu.org>
Acked-by: Peter Stuge <peter at stuge.se>

Modified:
   trunk/src/southbridge/nvidia/mcp55/mcp55_early_smbus.c

Modified: trunk/src/southbridge/nvidia/mcp55/mcp55_early_smbus.c
==============================================================================
--- trunk/src/southbridge/nvidia/mcp55/mcp55_early_smbus.c	Mon Nov  8 16:16:30 2010	(r6047)
+++ trunk/src/southbridge/nvidia/mcp55/mcp55_early_smbus.c	Mon Nov  8 18:41:43 2010	(r6048)
@@ -32,11 +32,8 @@
 	device_t dev;
 	dev = pci_locate_device(PCI_ID(0x10de, 0x0368), 0);
 
-	if (dev == PCI_DEV_INVALID) {
-		printk(BIOS_WARNING, "SMBUS controller not found\n");
-	} else {
-		printk(BIOS_DEBUG, "SMBus controller enabled\n");
-	}
+	if (dev == PCI_DEV_INVALID)
+		die("SMBus controller not found\n");
 
 	/* set smbus iobase */
 	pci_write_config32(dev, 0x20, SMBUS0_IO_BASE | 1);




More information about the coreboot mailing list