[coreboot] Patch for Nokia-IP530, now with working PIRQ table, fix on the pirq_routing
mbertens
mbertens at xs4all.nl
Thu May 27 12:45:14 CEST 2010
Signed-off-by: Marc Bertens <mbertens at xs4all.nl>
Part four for the Nokia IP530, This is the patch for hte devcetree.cb
file. Following changes where made;
- Disabled the floppy controller, due to the fact that its not present
on the board.
- Disabled tie parallel port, due to the fact that its not present on
the board.
- taken out the io, irq config of device 7 (PS2 keyb/mouse) it had not
effect anyways, and the controller is not used anyway, but it is
physical present on the board as a 4 pin sil header.
- Disabled the APCI of the superio, due to the fact that currently no
ACPI is supported by the current configuration of the Nokia IP530.
- Disabled the ACPI device of the southbridge, as above.
- Disabled the UBE device of the southbridge, as it has no connector on
the board.
- Set the ideX_driveY_udma33_enable to 1 to enable the UDMA33 option of
the southbridge (was tested with a 80Gb-WD and a CF 1Gb).
Remark: currently the CF that i used has the problem with DMA, and
therefor it takes Linux about 120 sec extra to boot. On a asus P4B
(orginal bios) this problem was not encountered. So therefor there must
be something be done extra in coreboot to fix that problem.
Marc
On Thu, 2010-05-27 at 12:30 +0200, mbertens wrote
>
> This is the patch for Kconfig, i have taken all unnessarry things out
> - back to default HEAP size
> - correct settings for the PIRQ table
> - with comments
>
> Marc
>
> On Thu, 2010-05-27 at 12:14 +0200, mbertens wrote:
>
> > Part two now the PIRQ table for the Nokia IP530.
> >
> > Changes made:
> > - rebuild the table to get th eNICs and PCMCIA controllers get there
> > correct IRQs assigned.
> > - Added a stub pirq_assign_irqs() due to the fact that it was missing at
> > compilation time. This was discussed with Rudolf Marek (ruik)
> > <r.marek at assembler.cz>
> >
> > Marc
> >
> >
> > On Thu, 2010-05-27 at 11:56 +0200, mbertens wrote:
> >
> > > Hi all,
> > >
> > > Here is the patch just for the pirq_routing() function. Its made
> > > specific to the CONFIG_NORTHBRIDGE_INTEL_440BX if that is to generic
> > > please replace by CONFIG_BOARD_NOKIA_IP530.
> > >
> > > Put the following extras in the file;
> > > - added header accordingly "Common License Header" that was missing.
> > > - corrected a printk() warning of the compiler.
> > > - added the correction for the i440BX by AND the link value with 0x5F
> > > so that always the value is kept below 0x5F. That AND value should be
> > > 0x03 i think because the link value cannot be greater than 3. But i'm
> > > not sure about that, thats why i used the current solution.
> > >
> > > The other patches will follow to day.
> > >
> > > Marc
> > >
> > >
> > >
> > > On Wed, 2010-05-26 at 15:14 -0600, Myles Watson wrote:
> > > > On Wed, May 26, 2010 at 2:15 PM, mbertens <mbertens at xs4all.nl> wrote:
> > > > > On Wed, 2010-05-26 at 11:00 -0600, Myles Watson wrote:
> > > > >> + // fix made by Marc Bertens <mbertens at xs4all.nl>
> > > > >> + if (link > 0x5f) {
> > > > >> + // This is basically for the 440BX
> > > > >> + link -= 0x5f;
> > > > >> + }
> > > > >>
> > > > >> I'd prefer this to be guarded by
> > > > >> #if CONFIG_NORTHBRIDGE_INTEL_440BX (or whatever the correct one is)
> > > > > I was thinking of it to put it that way, but i'd. But i will make the
> > > > > changes to the code.
> > > > >>
> > >
-------------- next part --------------
A non-text attachment was scrubbed...
Name: coreboot5593.devicetree.cb.Nokia-ip530.diff
Type: text/x-patch
Size: 3923 bytes
Desc: not available
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20100527/f1b9f2f6/attachment.diff>
More information about the coreboot
mailing list