[coreboot] Patch for Nokia-IP530, now with working PIRQ table, patch on 5591

Myles Watson mylesgw at gmail.com
Wed May 26 19:00:45 CEST 2010

+			// fix made by Marc Bertens <mbertens at xs4all.nl>
+			if (link > 0x5f) {
+				// This is basically for the 440BX
+				link -= 0x5f;
+			}

I'd prefer this to be guarded by 
#if CONFIG_NORTHBRIDGE_INTEL_440BX (or whatever the correct one is)

It would also be nice to have an explanation.

The rest of your patch touches a lot of code with little explanation.  It
takes a lot more time to review patches like that.  For a faster review you
should split it up into pieces that add functionality.  For example, the
heap size (which seems really large) part of the patch should have an
explanation of what problem you see with a normal heap size.


More information about the coreboot mailing list