[coreboot] [commit] r5581 - trunk/src/southbridge/amd/cs5536

repository service svn at coreboot.org
Sun May 23 06:50:42 CEST 2010

Author: stuge
Date: Sun May 23 06:50:41 2010
New Revision: 5581
URL: https://tracker.coreboot.org/trac/coreboot/changeset/5581

Fix bug from r5476 re CS5536 device search during GeodeLX PCI domain enable

cs5536.c:chipsetinit() is called during northbridge pci_domain_enable()
which happens before scan_bus() so the device tree does not have PCI
vendor/device ids yet. Let's use dev_find_slot() for now. This works
only as long as the CS5536 has PCI device id 0xf in all mainboards,
and a better solution is needed in case that ever changes!

Signed-off-by: Peter Stuge <peter at stuge.se>
Acked-by: Nathan Williams <nathan at traverse.com.au>


Modified: trunk/src/southbridge/amd/cs5536/cs5536.c
--- trunk/src/southbridge/amd/cs5536/cs5536.c	Sat May 22 17:07:15 2010	(r5580)
+++ trunk/src/southbridge/amd/cs5536/cs5536.c	Sun May 23 06:50:41 2010	(r5581)
@@ -530,8 +530,7 @@
 	struct southbridge_amd_cs5536_config *sb;
 	struct msrinit *csi;
-	dev = dev_find_device(PCI_VENDOR_ID_AMD,
+	dev = dev_find_slot(0, PCI_DEVFN(0xf, 0));
 	if (!dev) {
 		printk(BIOS_ERR, "CS5536 not found.\n");

More information about the coreboot mailing list