[coreboot] [PATCH] Improve i82830 MBI SMI Handler

Joseph Smith joe at settoplinux.org
Fri May 21 22:51:52 CEST 2010

On 05/21/2010 03:17 PM, Stefan Reinauer wrote:
> On 5/21/10 7:25 AM, Joseph Smith wrote:
>> This patch improves the i82830 MBI SMI Handler. It is now able to load
>> Intel vbios VBT and Flexaim modules. Build and boot tested.
>> Signed-off-by: Joseph Smith <joe at settoplinux.org>
> God catch...
> However, please don't commit this... it breaks the implementation of
> MBI, the code should stay completely module agnostic. There should be a
> solution that works without adding an exception for every module supported
> (plus, I think the rules are based on the length of the name, so any
> module 203 and 204 with different names will break your assumptions.
Even the existing code is not "completely module agnostic". There are 
little + _some_number_ through out the code to adjust the data structure 

Joseph Smith

More information about the coreboot mailing list