[coreboot] [commit] r5577 - trunk/src/cpu/amd/model_10xxx

repository service svn at coreboot.org
Fri May 21 19:15:56 CEST 2010

Author: myles
Date: Fri May 21 19:15:55 2010
New Revision: 5577
URL: https://tracker.coreboot.org/trac/coreboot/changeset/5577

Get rid of this warning:
	warning: 'fid_max' may be used uninitialized in this function

Quoting Marc:

It [fid_max] should be initialized to 0. The !nb_cof_vid_update would mean that
the fidmax shouldn't change so the value isn't important, but 0 would be the
safest if there is another hole in the logic and CPUs are not matched.

Signed-off-by: Myles Watson <mylesgw at gmail.com>
Acked-by: Myles Watson <mylesgw at gmail.com>


Modified: trunk/src/cpu/amd/model_10xxx/fidvid.c
--- trunk/src/cpu/amd/model_10xxx/fidvid.c	Fri May 21 16:33:48 2010	(r5576)
+++ trunk/src/cpu/amd/model_10xxx/fidvid.c	Fri May 21 19:15:55 2010	(r5577)
@@ -755,7 +755,7 @@
 	struct fidvid_st fv;
 	device_t dev;
 	u32 vid_max;
-	u32 fid_max;
+	u32 fid_max=0;
 	u8 nb_cof_vid_update;
 	u32 reg1fc;
 	u8 pvimode;

More information about the coreboot mailing list