[coreboot] [PATCH]Move generation of ISA bus mptable entries togeneric code
patrick at georgi-clan.de
Thu May 20 17:29:29 CEST 2010
Am 20.05.2010 17:00, schrieb Myles Watson:
>> #define IO_LOCAL_INT(type, intr, apicid, pin) \
>> smp_write_intsrc(mc, (type), MP_IRQ_TRIGGER_EDGE |
> MP_IRQ_POLARITY_HIGH, bus_isa, (intr), (apicid), (pin));
>> - IO_LOCAL_INT(mp_ExtINT, 0x0, apicid_sb700, 0x0);
>> + mptable_add_isa_interrupts(mc, bus_isa, apicid_sb700, 0);
> It looks like IO_LOCAL_INT should be removed, since it uses bus_isa. Same
> for tilapia & probably other similar mainboards.
It's still used for some other table entry, so I kept it. Once that
entry is gone (I think it can be made generic, too), I'll remove the macro.
With all done, it might be possible to drop board specific mptable.c's
completely, which would also fix this issue.
>> + /*I/O Ints: Type Polarity Trigger
> Bus ID IRQ APIC ID PIN# */
>> smp_write_intsrc(mc, mp_INT,
> MP_IRQ_TRIGGER_LEVEL|MP_IRQ_POLARITY_LOW, m->bus_mcp55, ((sbdn+1)<<2)|1,
> m->apicid_mcp55, 0xa);
> In some places you reformat the comment, in others you just remove it.
And the comment doesn't even exist in all files - mptable.c isn't very
consistent to begin with. I guess this happened because some files had
/* comment here
*/ code I removed on the same line as the comment end
Committed as r5575, thank you for the Ack.
More information about the coreboot