[coreboot] [PATCH]Move generation of ISA bus mptable entries to generic code

Patrick Georgi patrick at georgi-clan.de
Thu May 20 16:25:54 CEST 2010


attached patch moves the mptable entries for ISA bus interrupts (ie. the
legacy stuff) to generic code.
Instead of the hogde-podge in each board's mptable.c, it's relatively
clean code in arch/i386 now.

There are some changes, but I think they don't matter:

- no more "DEFAULT" configuration for the ISA interrupts, they're always
explicitely EDGE/LOW now. As ISA is specified that way, DEFAULT should
lead to the same result.

- fully specified interrupt map from 1 to 15: Some boards didn't specify
various irqs (some of irq 3, 8, 9, 10, 11 were commonly left out).
Either these are actually in use, in which case we better provide an
entry, or they're not, in which case these entries won't hurt (as far as
I can see)

The new function uses an mptable_ prefix. The smp_ prefix is less
descriptive, but I didn't want to rename all of this in one go. As I
plan to move more code out of the individual mptable.c files, I'd like
to hold off with any rename until that's settled down.

The long term goal would be to have coreboot generate the mptable
according to the actual bus situation instead of this mostly (but not
entirely) hardcoded table.
Moving common code sequences out is the first step, after that I'll see
how to store the data required for the mptable generation (eg. IOAPIC
information) in the device tree.

As this is quite a large patch, affecting lots of boards, I'd welcome
some review that I didn't delete a line too much or something like that.

It's abuild tested and
Signed-off-by: Patrick Georgi <patrick.georgi at coresystems.de>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 20100520-1-unify-mptable-isa-entries-generation.diff
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20100520/c37b87cf/attachment.ksh>

More information about the coreboot mailing list