[coreboot] [PATCH] make AMD CAR disable a C function
Kevin O'Connor
kevin at koconnor.net
Mon May 17 02:10:40 CEST 2010
On Mon, May 17, 2010 at 12:10:50AM +0200, Rudolf Marek wrote:
> > What's not clear to me is how to handle S3 resume. I would think we'd
> > want an ability to disable CAR and place the new stack somewhere other
> > than CONFIG_RAMTOP.
>
> Well check my patch
> http://patchwork.coreboot.org/patch/1266/
>
> I just backup the memory right before I place there the stack, because not
> only stack is used, some sysinfo datastructures needs to be copied of
> CAR too.
Okay. So, resume is more like:
tinybootblock->romstage->backupmem->ramstage->restoremem->OS
It seems to me that the AMD car disable code is too complex. I find
the VIA car code much easier to follow.
-Kevin
More information about the coreboot
mailing list