[coreboot] [PATCH] make AMD CAR disable a C function

Kevin O'Connor kevin at koconnor.net
Sun May 16 23:34:42 CEST 2010

On Sun, May 16, 2010 at 09:55:58PM +0200, Patrick Georgi wrote:
> Am 16.05.2010 19:50, schrieb Kevin O'Connor:
> > void romstage(u32 bist) {
> >     ...
> >     disable_car(load_ramstage, bist, CONFIG_RAMTOP)
> > }
> Where would this code reside? Hopefully not (in this verbosity) in every
> boards' romstage.c?
> load_ramstage and the new stack location shouldn't be board specific
> (and shouldn't need to be). With both pretty much set in stone, only
> bist needs to be brought over.

I agree with Stefan that the code that calls romstage() should also
call disable_car() - no need to repeat the code in every board.

What's not clear to me is how to handle S3 resume.  I would think we'd
want an ability to disable CAR and place the new stack somewhere other

I'm still a bit confused on what the code flow is today during an S3
resume.  (Is it, tinybootblock->romstage->ramstage->restorememory->OS?)


More information about the coreboot mailing list