[coreboot] [PATCH]Include headers instead of sources in romstage, part 1/many

Patrick Georgi patrick at georgi-clan.de
Sat May 8 00:13:19 CEST 2010


attached patch drops console/console.c and pc80/serial.c from the
mainboards' romstage.c. console/console.h is included instead.

On CAR builds, console/console.c is built separately and linked to the
romstage, on romcc builds, this includes console/console.c from within
The romcc variant helps with uniformity.

In the same way, pc80/serial.c is eliminated from romstage.c. The
necessary prototypes were already included via some other paths.

Both files needs to include arch/io.h for separate compilation, so it
finds outb, so it's moved outside the #ifndef __PRE_RAM__ in console.c
and added in serial.c

The patch also removes two superfluous ARRAY_SIZE definitions (in
amd/db800 and winent/pl6064)

It's abuild tested and

Signed-off-by: Patrick Georgi <patrick.georgi at coresystems.de>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 20100507-2-reduce-c-in-c-includes.diff
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20100508/591a62fd/attachment.ksh>

More information about the coreboot mailing list