[coreboot] [commit] r5286 - ...

[Stefan Reinauer]

On 3/25/10 3:47 PM, Myles Watson wrote:
>>> On 3/24/10 11:02 PM, repository service wrote:
>>>       
>>>> -extern unsigned char AmlCode[];
>>>> +extern const acpi_header_t AmlCode;
>>>>         
>>> And we're positive, this always does the right thing with gcc?
>>>       
>> I am told that AmlCode is defined as array of (unsigned) char in
>> some other file.  Declaring it as some other type here is not
>> valid C, and *will* break with GCC, with some options (-combine
>> or LTO at least) -- it will not compile.
>>     
> The biggest worry for me is incorrect execution.  If it doesn't compile when
> it breaks, then that's a good thing.
>   
Well, if it breaks with LTO, we should fix it right away... I'll try and
prepare something.


-- 
coresystems GmbH • Brahmsstr. 16 • D-79104 Freiburg i. Br.
      Tel.: +49 761 7668825 • Fax: +49 761 7664613
Email: info at coresystems.de  • http://www.coresystems.de/
Registergericht: Amtsgericht Freiburg • HRB 7656
Geschäftsführer: Stefan Reinauer • Ust-IdNr.: DE245674866