[coreboot] W83977EF vs. ASUS P2B-L vs. PS/2 keyboard

ron minnich rminnich at gmail.com
Tue Mar 23 16:02:25 CET 2010


On Mon, Mar 22, 2010 at 6:38 AM, Mark Marshall <mark.marshall at csr.com> wrote:

>
> Change
>
> 152     void pnp_enable(device_t dev)
> 153     {
> 154             if (!dev->enabled) {
> 155                     pnp_set_logical_device(dev);
> 156                     pnp_set_enable(dev, 0);
> 157             }
> 158     }

the pnp code was never quite finished in some ways ...
 void pnp_enable(device_t dev)
void pnp_enable(device_t dev
 {
> 154             if (!dev->enabled) {
> 155                     pnp_set_logical_device(dev);
> 156                     pnp_set_enable(dev, 0);
> 157             } else {
> 155                     pnp_set_logical_device(dev);
> 156                     pnp_set_enable(dev, 1);
}


sorry for formatting, I'm where it's not easy to do.

So if it's not enabled, disable it; else enable it.

Others can comment on whether this is going to be a bad idea.

ron




More information about the coreboot mailing list