[coreboot] Ouch: romcc "x[0] |= something" patch causes another crash
Eric W. Biederman
ebiederm at xmission.com
Tue Mar 16 01:31:11 CET 2010
Stefan Reinauer <stepan at coresystems.de> writes:
> Seems to do the job... Please send a Signed-off-by: for the books:
> http://www.coreboot.org/Development_Guidelines#Sign-off_Procedure
Signed-off-by: "Eric W. Biederman" <ebiederm at xmission.com>
> and this will make it into the tree.
>
> You can of course check it in yourself if you wish, in any case this is
> Acked-by: Stefan Reinauer <stepan at coresystems.de>
Just my bad habit of not signing off on patches I haven't even tested.
>> Index: romcc.c
>> ===================================================================
>> --- romcc.c (revision 4892)
>> +++ romcc.c (working copy)
>> @@ -13458,6 +13458,10 @@
>> if ((type->type & TYPE_MASK) == TYPE_FUNCTION) {
>> error(state, 0, "Function prototypes not supported");
>> }
>> + if (ident &&
>> + ((type->type & TYPE_MASK) == TYPE_ARRAY) &&
>> + ((type->type & STOR_MASK) != STOR_STATIC))
>> + error(state, 0, "non static arrays not supported");
>> if (ident &&
>> ((type->type & STOR_MASK) == STOR_STATIC) &&
>> ((type->type & QUAL_CONST) == 0)) {
>>
Eric
More information about the coreboot
mailing list