[coreboot] [PATCH] spd_rom FIX H8QME-2+

Myles Watson mylesgw at gmail.com
Fri Mar 12 17:09:58 CET 2010

On Fri, Mar 12, 2010 at 4:00 AM, Knut Kujat <knuku at gap.upv.es> wrote:

> Hello,
> this patch fixes the issue where the board wasn't able to start after
> getting unplugged. I also added some GPIOs so now the power on led is
> working.

The spacing doesn't look like it follows these guidelines:

 static inline void activate_spd_rom(const struct mem_controller *ctrl)
-    /* nothing to do */
+#define SMBUS_SWITCH1 0x70
+#define SMBUS_SWITCH2 0x72
+//     unsigned device=(ctrl->spd_addr[0])>>8;
It's unclear what this comment is for.  Maybe just drop it?

Signed-off-by: Knut Kujat <knuku at gap.upv.es>

With the formatting and comment addressed:
Acked-by: Myles Watson <mylesgw at gmail.com>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20100312/4d423a98/attachment.html>

More information about the coreboot mailing list