[coreboot] HELP: Porting i830 RAM init to 440BX, now it won't compile

[Keith Hui]

On Tue, Mar 2, 2010 at 12:53 PM, Joseph Smith <joe at settoplinux.org> wrote:

>
>
>
> On Tue, 2 Mar 2010 11:43:42 -0500, Keith Hui <buurin at gmail.com> wrote:
> > On Tue, Mar 2, 2010 at 11:22 AM, ron minnich <rminnich at gmail.com> wrote:
> >
> >> On Tue, Mar 2, 2010 at 5:39 AM, Keith Hui <buurin at gmail.com> wrote:
> >>
> >> > ramtest.c:6.0: warning: Replacing undefined macro: CONFIG_SSE2 with 0
> >> > ramtest.c:56.0: warning: Replacing undefined macro: CONFIG_SSE2 with 0
> >>
> This should be fixed in Kconfig. Probibly in the cpu Kconfig?
>
> >> fix this first. You really want your code to be warning-free.
> >>
> >> I did a search, and the only reference (ie. this ramtest.c) is elsewhere
> > in
> > the code - src/lib/. That may be used by something else.
> >
> >>
> >> >                 edosd |= 0x04;  // <<< ABORT!
> >>
> >> did you try just edosd = edosd | 4;
> >>
> >> just wondering if it's that simple.
> >>
> >> I could try tonight. But I used both notations fearing that romcc
> doesn't
> > support more obscure constructs, and both work in other places.
> >
> hmm
>
I did it - I made the above change (though I doubt it made any difference)
and have to remove the PRINT_DEBUG mentioned in my original email for it to
compile.

Time to boot test.

* Clacks away *

This is the biggest excitement after Canada winning Hockey Gold at the
winter Olympics! (see attached log)

I have 256MB and Linux boots to the login prompt!

I'll formulate a patch later adding this and P2B-LS support.

Cheers
Keith
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20100302/9395b250/attachment.html>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: coreboot run log 5 p2bls.txt
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20100302/9395b250/attachment.txt>