[coreboot] PATCH: Fix CMOS Tables support for all boards.

Myles Watson mylesgw at gmail.com
Fri Jun 25 00:43:01 CEST 2010


On Thu, Jun 24, 2010 at 7:08 AM, Edwin Beasant
<edwin_beasant at virtensys.com> wrote:
> Re-integrated the “USE_OPTION_TABLE” code so that it will compile for all
> boards that define it at configure time.
>
> Made USE_OPTION_TABLE dependant on HAVE_OPTION_TABLE
>
> Signed-off-by: Edwin Beasant edwin_beasant at virtensys.com

Thanks for doing this.  I have a couple of questions:

- Can we have the option disappear in Kconfig without having to define
USE_OPTION_TABLE with an #ifdef?  I'd like it if that could stay in
Kconfig.
- Why is the prototype for read_option conditionally defined when the
function is always defined?
- Why is read_option inline?
- How does an inlined function get called when it's compiled into an initobj?

Thanks,
Myles




More information about the coreboot mailing list