[coreboot] [PATCH] Simplify device enabling and initialization

Myles Watson mylesgw at gmail.com
Thu Jun 17 18:40:12 CEST 2010


On Wed, Jun 16, 2010 at 6:22 PM, Ward Vandewege <ward at gnu.org> wrote:
> On Wed, Jun 16, 2010 at 02:50:42PM -0600, Myles Watson wrote:
>> This patch breaks the s2881, which was doing some odd acrobatics in
>> order to get a device initialized after its parent.  It should be an
>> easy fix to do it correctly now, but I don't have an s2881 to test on.
>>  Ward?
>
> Yep, I've got (the guts) of an s2881 lying on my desk here, and can test any
> patches you throw at me :)

Great.  Here are two patches.

The first one enables the driver exactly like it was before, only as a driver.

The second one tries to make it less board specific.  Putting the fan
settings in the device tree would complete that effort, I think.

Suggestions welcome.  Thanks for testing!

Signed-off-by: Myles Watson <mylesgw at gmail.com>

Thanks,
Myles
-------------- next part --------------
A non-text attachment was scrubbed...
Name: s2881.diff
Type: text/x-diff
Size: 2122 bytes
Desc: not available
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20100617/983c7908/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: s2881_2.diff
Type: text/x-diff
Size: 3529 bytes
Desc: not available
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20100617/983c7908/attachment-0001.bin>


More information about the coreboot mailing list