[coreboot] [PATCH] Simplify device enabling and initialization
Stefan Reinauer
stepan at coresystems.de
Thu Jun 17 00:13:32 CEST 2010
Hi Myles,
I like the patch, but it looks like you're wiping calls to adt7463
initialization on the s2881 completely with no replacement. is that on
purpose?
Stefan
On 6/16/10 10:50 PM, Myles Watson wrote:
> Index: svn/src/mainboard/tyan/s2881/mainboard.c
> ===================================================================
> --- svn.orig/src/mainboard/tyan/s2881/mainboard.c
> +++ svn/src/mainboard/tyan/s2881/mainboard.c
> @@ -98,56 +98,6 @@ static void adt7463_init(device_t dev)
> printk(BIOS_DEBUG, "ADT7463 properly initialized\n");
> }
>
> -static void dummy_noop(device_t dummy)
> -{
> -}
> -
> -static struct device_operations dummy_operations = {
> - .read_resources = dummy_noop,
> - .set_resources = dummy_noop,
> - .enable_resources = dummy_noop,
> - .init = adt7463_init,
> -};
> -
> -static unsigned int scan_root_bus(device_t root, unsigned int max)
> -{
> - struct device_path path;
> - device_t dummy;
> -
> - max = root_dev_scan_bus(root, max);
> -
> - printk(BIOS_DEBUG, "scan_root_bus ok\n");
> -
> - /* The following is a little silly. We need a hook into the boot
> - * process *after* the ADT7463 device has been initialized. So we
> - * create this dummy device, and we put the ADT7463 S2881 specific
> - * settings in its init function, which gets called
> - * as the last device to be initialized.
> - */
> -
> - path.type = DEVICE_PATH_PNP;
> - path.pnp.port = 0;
> - path.pnp.device = 0;
> - dummy = alloc_dev(root->link_list, &path);
> - dummy->ops = &dummy_operations;
> -
> - return max;
> -}
> -
> -static struct device_operations mainboard_operations = {
> - .read_resources = root_dev_read_resources,
> - .set_resources = root_dev_set_resources,
> - .enable_resources = root_dev_enable_resources,
> - .init = root_dev_init,
> - .scan_bus = scan_root_bus,
> -};
> -
> -static void enable_dev(struct device *dev)
> -{
> - dev->ops = &mainboard_operations;
> -}
> -
> struct chip_operations mainboard_ops = {
> CHIP_NAME("Tyan S2881 Mainboard")
> - .enable_dev = enable_dev,
> };
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20100617/b2e00f2b/attachment.html>
More information about the coreboot
mailing list