[coreboot] [PATCH] Fix geode lx VSA loading

Stefan Reinauer stepan at coresystems.de
Fri Jun 4 18:57:09 CEST 2010


On 6/4/10 6:40 PM, Stefan Reinauer wrote:
> On 6/4/10 6:37 PM, Patrick Georgi wrote:
>   
>> Am Freitag, den 04.06.2010, 16:25 +0100 schrieb Edwin Beasant:
>>   
>>     
>>> This patch fixes the option rom code that was buggy when it switched
>>> segment registers before restoring register values. This was breaking
>>> the Geode VSA, and probably would have hurt other option roms as well.
>>>
>>>  
>>>
>>> Signed-off by: Edwin Beasant edwin_beasant at virtensys.com
>>>     
>>>       
>> Except for the first two parts (the magic values in ecx/edx and
>> whitespace), and assuming this is tested, the patch is
>>
>> Acked-by: Patrick Georgi <patrick.georgi at coresystems.de>
>>
>>
>>   
>>     
> I did a new version of the patch with those issues fixed (and pushing
> one register instead of all), see attachment
>
> Signed-off-by: Edwin Beasant <edwin_beasant at virtensys.com>
> Signed-off-by: Stefan Reinauer <stepan at coresystems.de>
>   
Updated patch.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20100604/6338b00e/attachment.html>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: vsa2.diff
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20100604/6338b00e/attachment.ksh>


More information about the coreboot mailing list