[coreboot] Patch: Update Geode LX code to avoid FILO/Kernel problems

ron minnich rminnich at gmail.com
Wed Jan 27 18:26:39 CET 2010


-               ram_resource(dev, idx++, 768, 1024); // c0000-fffff are usable
-               ram_resource(dev, idx++, 1024, tomk - 1024);    //
Systop - 1 MB -> KB
+               //ram_resource(dev, idx++, 768, 1024); // c0000-fffff are usable
+               ram_resource(dev, idx++, 768, tomk - 768);      //
Systop - 1 MB -> KB

Commented out code has proven to be confusing in the past.
Any reason for leaving the commented-out line in there? I see it
possibly leading to confusion.

Could we go from 768 to comething like:
0xc * 65536 or something? Make it really clear that it's the C segment?

Rather than commented-out code, maybe a descriptive comment so people
who come later can know what you did? The resource code can be
inscrutable ...

thanks

ron




More information about the coreboot mailing list