[coreboot] [PATCH]unify mainboard makefiles

Myles Watson mylesgw at gmail.com
Sat Feb 27 00:40:05 CET 2010

On Fri, Feb 26, 2010 at 3:38 PM, Patrick Georgi <patrick at georgi-clan.de>wrote:

> Hi,
> after moving crt0s and lscripts away from the mainboards' Makefiles,
> those Makefiles are rather simple now, with more opportunities to move
> out things.
> Attached patch does:
> - make HAVE_HARD_RESET match what newconfig did
> - introduce BOARD_HAS_HARD_RESET and use it if a board provides
> hard_reset in $(MAINBOARDDIR)/reset.c, instead of some chipset component
> - move a couple of rules out of the mainboards' Makefiles into
> src/arch/i386/Makefile.inc:
>        initobj-y += crt0.o
>        obj-y += mainboard.o
>        obj-$(CONFIG_GENERATE_MP_TABLE) += mptable.o
>        obj-$(CONFIG_GENERATE_PIRQ_TABLE) += irq_tables.o
>        obj-$(CONFIG_BOARD_HAS_HARD_RESET) += reset.o
> - remove Makefile.incs that are empty (or comment-only) after these
> changes, incl. Makefile.romccboard.inc (and references to it)
> - Make include not fail if file doesn't exist.
> reset.o used to be HAVE_HARD_RESET, but to make this rule more
> universal, that new variable had to be introduced.
Can we put HAVE_HARD_RESET into the ck804 Kconfig instead of into all the
ck804 mainboards?

> It's build tested and has no regression vs. current HEAD (ie. the same
> two boards fail for the same reason) and is boot tested on
> kontron/986lcd-m.
> Signed-off-by: Patrick Georgi <patrick.georgi at coresystems.de>
Acked-by: Myles Watson <mylesgw at gmail.com>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20100226/4648428c/attachment.html>

More information about the coreboot mailing list