[coreboot] [PATCH]Hide crt0s from user

ron minnich rminnich at gmail.com
Thu Feb 25 17:59:07 CET 2010


On Thu, Feb 25, 2010 at 8:51 AM, Patrick Georgi <patrick at georgi-clan.de> wrote:
> Am 25.02.2010 16:27, schrieb Uwe Hermann:

> At least those that require it for enable_mmx.inc and the like are set
> correctly.

be careful here. I had one problem at one point where the CPU was
taking a GPF because enable_sse.inc was included. The issue was that
the code had the CPU touch an SSE register that did not exist -->
BOOM.

Are you sure that you are carefully checking the feature set and not
touching sse.inc if it is not there and/or not assembling that code if
the CPU does not support it? I'm sorry, have not looked at your code
;-( but wanted to warn you. I assume that no sse instructions are
executed unless the feature is known to exist.

But this is another huge improvement that i think we have to just push
our way through to making it work no matter what!

Thanks

ron




More information about the coreboot mailing list