[coreboot] [commit] r5083 - trunk/src/mainboard/tyan/s2881

repository service svn at coreboot.org
Thu Feb 4 04:03:39 CET 2010


Author: ward
Date: Thu Feb  4 04:03:39 2010
New Revision: 5083
URL: http://tracker.coreboot.org/trac/coreboot/changeset/5083

Log:
Revision 5051 broke Kconfig booting for the Tyan s2881 board. Up to 5050, there
were two SB_HT_CHAIN_ON_BUS0 sections in the mainboard Kconfig file - one
setting the parameter to 0, the other setting it to 2.

Revision 5051 removed one of the two SB_HT_CHAIN_ON_BUS0 sections - the wrong
one. This patch fixes that.

Revision 5051 removed the wrong setting because newconfig for this board was
*also* wrong. This patch fixes that too.

Tested on real hardware, both with Kconfig and newconfig.

Signed-off-by: Ward Vandewege <ward at gnu.org>
Acked-by: Patrick Georgi <patrick.georgi at coresystems.de>
Acked-by: Stefan Reinauer <stepan at coresystems.de>

Modified:
   trunk/src/mainboard/tyan/s2881/Kconfig
   trunk/src/mainboard/tyan/s2881/Options.lb

Modified: trunk/src/mainboard/tyan/s2881/Kconfig
==============================================================================
--- trunk/src/mainboard/tyan/s2881/Kconfig	Thu Feb  4 02:32:43 2010	(r5082)
+++ trunk/src/mainboard/tyan/s2881/Kconfig	Thu Feb  4 04:03:39 2010	(r5083)
@@ -24,7 +24,7 @@
 
 config SB_HT_CHAIN_ON_BUS0
 	int
-	default 0
+	default 2
 	depends on BOARD_TYAN_S2881
 
 config LB_CKS_RANGE_END

Modified: trunk/src/mainboard/tyan/s2881/Options.lb
==============================================================================
--- trunk/src/mainboard/tyan/s2881/Options.lb	Thu Feb  4 02:32:43 2010	(r5082)
+++ trunk/src/mainboard/tyan/s2881/Options.lb	Thu Feb  4 04:03:39 2010	(r5083)
@@ -128,7 +128,7 @@
 default CONFIG_HT_CHAIN_END_UNITID_BASE=0x06
 
 #make the SB HT chain on bus 0, default is not (0)
-default CONFIG_SB_HT_CHAIN_ON_BUS0=0
+default CONFIG_SB_HT_CHAIN_ON_BUS0=2
 
 ##only offset for SB chain?, default is yes(1)
 #default CONFIG_SB_HT_CHAIN_UNITID_OFFSET_ONLY=0




More information about the coreboot mailing list