[coreboot] [PATCH 2/7] Geode GX2 cleanup next round
Myles Watson
mylesgw at gmail.com
Thu Dec 30 02:44:12 CET 2010
On Wed, Dec 29, 2010 at 4:46 PM, Nils <njacobs8 at hetnet.nl> wrote:
> Op woensdag 29 december 2010 21:44:08 schreef u:
>> On Wed, Dec 29, 2010 at 12:04 PM, Nils <njacobs8 at hetnet.nl> wrote:
>> > Add a MSR printing function to northbridge.c like in the Geode LX code.
>>
>> It's surprising to have it included
>>
>> +#if CONFIG_DEFAULT_CONSOLE_LOGLEVEL >= BIOS_ERR
>>
>> but then have all the print statements be BIOS_DEBUG.
>>
>> Thanks,
>> Myles
>
> You are right, i copied it from Geode LX and didn't notice it.
> Should i make a patch to change it on GX2 and LX to BIOS_DEBUG ?
It's up to you. I think there could be a better way to handle it, but
there are many ways to change it.
Thanks,
Myles
More information about the coreboot
mailing list