[coreboot] [PATCH 2/7] Geode GX2 cleanup next round

Nils njacobs8 at hetnet.nl
Thu Dec 30 00:46:52 CET 2010


Op woensdag 29 december 2010 21:44:08 schreef u:
> On Wed, Dec 29, 2010 at 12:04 PM, Nils <njacobs8 at hetnet.nl> wrote:
> > Add a MSR printing function to northbridge.c like in the Geode LX code.
> 
> It's surprising to have it included
> 
> +#if CONFIG_DEFAULT_CONSOLE_LOGLEVEL >= BIOS_ERR
> 
> but then have all the print statements be BIOS_DEBUG.
> 
> Thanks,
> Myles

You are right, i copied it from Geode LX and didn't notice it.
Should i make a patch to change it on GX2 and LX to BIOS_DEBUG ?

Thanks, Nils.




More information about the coreboot mailing list