[coreboot] [PATCH] Cleanup up HD audio codec / hda_verb.h files

Uwe Hermann uwe at hermann-uwe.de
Wed Dec 15 10:05:03 CET 2010

On Sat, Dec 11, 2010 at 01:29:09PM -0800, Stefan Reinauer wrote:
> On 12/11/10 12:57 PM, Peter Stuge wrote:
> > Uwe Hermann wrote:
> >> Cleanup up HD audio codec / hda_verb.h files.
> > ..
> >> Signed-off-by: Uwe Hermann <uwe at hermann-uwe.de>
> > Acked-by: Peter Stuge <peter at stuge.se>

Thanks, r6180.

> However, please refrain from removing the verb adding code from those
> boards that actually have sound jacks. It makes no sense to remove the
> codecs and add the same code later on. Instead it should just be fixed
> as soon as the right information is known for those boards.

OK, I kept the files for now, though we should probably only keep the code
in mainboard.c (commented out) and kill the definately useless hda_verb.h
files, IMHO.

http://hermann-uwe.de     | http://sigrok.org
http://randomprojects.org | http://unmaintained-free-software.org

More information about the coreboot mailing list