[coreboot] [commit] r6127 - in trunk/src: mainboard/asus/p2b northbridge/intel/i440bx/acpi southbridge/intel/i82371eb southbridge/intel/i82371eb/acpi

Tobias Diedrich ranma+coreboot at tdiedrich.de
Wed Dec 8 22:47:20 CET 2010


Peter Stuge wrote:
> Tobias Diedrich wrote:
> > Here is a solution using the SSDT.
> > 
> > Unfortunately iasl does not resolve simple arithmetic at compile
> > time, so we can not use Add(DEFAULT_PMBASE, PCNTRL) in the
> > Processor statement.
> > This patch instead dynamically generates the processor statement.
> > I can't use the speedstep generate_cpu_entries() directly since the
> > cpu doesn't support speedstep.
> > For now the code is in the southbridge directory, but maybe it
> > should go into cpu/intel/ somewhere.
> > IIRC notebook cpus of the era can already have speedstep, so it
> > would probably be possible to pair the i82371eb with a
> > speedstep-capable cpu...
> > Also, I don't know if multiprocessor boards (abit bp6?) would need
> > to be handled differently.
> > 
> > Abuild-tested.
> > 
> > Signed-off-by: Tobias Diedrich <ranma+coreboot at tdiedrich.de>
> 
> Not lovely to generate something that is so simple, but sure, if it
> works.
> 
> Acked-by: Peter Stuge <peter at stuge.se>

Thanks, committed as r6153.
Damn, three added empty files sneaked in from the other parts of the
quilt patch set, removed by r6154.

-- 
Tobias						PGP: http://8ef7ddba.uguu.de




More information about the coreboot mailing list