[coreboot] [PATCH] Move "select CACHE_AS_RAM" lines from boards into CPU socket
Stefan Reinauer
stepan at coreboot.org
Tue Dec 7 23:11:23 CET 2010
* Stefan Reinauer <stepan at coreboot.org> [101207 23:06]:
> * Patrick Georgi <patrick at georgi-clan.de> [101207 16:35]:
> > Am 06.12.2010 23:45, schrieb Uwe Hermann:
> > > See patch.
> > src/cpu/Kconfig defines CACHE_AS_RAM to "!ROMCC", so I think these can
> > be dropped completely. Right?
> >
> > We basically assume it's CAR unless romcc is used.
>
> This seems to make a lot of sense.
>
> Do we need this stuff in Kconfig at all?
There are only very few places in the Makefile that need the
distinction:
./src/arch/i386/Makefile.inc:ifeq ($(CONFIG_ROMCC),y)
./src/arch/i386/Makefile.inc:ifeq ($(CONFIG_ROMCC),y)
./src/pc80/Makefile.inc:romstage-$(CONFIG_CACHE_AS_RAM) += serial.c
./src/console/Makefile.inc:romstage-$(CONFIG_CACHE_AS_RAM) += console.c
./src/lib/Makefile.inc:romstage-$(CONFIG_CACHE_AS_RAM) += ramtest.c
And some in the .c files, but I think it would be safe to replace those
#if CONFIG_CACHE_AS_RAM with #ifndef __ROMCC__
Stefan
More information about the coreboot
mailing list