[coreboot] [commit] r5730 - in trunk/src: cpu/amd/model_10xxx northbridge/amd/amdmct

[repository service]

Author: stepan
Date: Sun Aug 22 21:48:29 2010
New Revision: 5730
URL: https://tracker.coreboot.org/trac/coreboot/changeset/5730

Log:
Include RB_C3 in erratum 346

Signed-off-by: Xavi Drudis Ferran <xdrudis at tinet.cat>
Acked-by: Stefan Reinauer <stepan at coresystems.de>

Modified:
   trunk/src/cpu/amd/model_10xxx/defaults.h
   trunk/src/northbridge/amd/amdmct/amddefs.h

Modified: trunk/src/cpu/amd/model_10xxx/defaults.h
==============================================================================
--- trunk/src/cpu/amd/model_10xxx/defaults.h	Sun Aug 22 21:45:57 2010	(r5729)
+++ trunk/src/cpu/amd/model_10xxx/defaults.h	Sun Aug 22 21:48:29 2010	(r5730)
@@ -290,9 +290,9 @@
 					   [5] DisPciCfgCpuMstAbtRsp = 1,
 					   [1] SyncFloodOnUsPwDataErr = 1 */
 
-	/* errata 346 - Fam10 C2
+	/* errata 346 - Fam10 C2 -- FIXME at 25.6.2010 should apply to BL-C[23] too but I can't find their constants
 	 *  System software should set F3x188[22] to 1b. */
-	{ 3, 0x188, AMD_RB_C2 | AMD_DA_C2 | AMD_DA_C3, AMD_PTYPE_ALL,
+	{ 3, 0x188, AMD_DR_Cx, AMD_PTYPE_ALL,
 	  0x00400000, 0x00400000 },
 
 	/* L3 Control Register */

Modified: trunk/src/northbridge/amd/amdmct/amddefs.h
==============================================================================
--- trunk/src/northbridge/amd/amdmct/amddefs.h	Sun Aug 22 21:45:57 2010	(r5729)
+++ trunk/src/northbridge/amd/amdmct/amddefs.h	Sun Aug 22 21:48:29 2010	(r5730)
@@ -66,6 +66,7 @@
 #define	AMD_FAM10_GT_B0	(AMD_FAM10_ALL & ~(AMD_DR_B0))
 #define	AMD_DR_Cx       (AMD_RB_C2 | AMD_DA_C2 | AMD_RB_C3 | AMD_DA_C3)
 #define	AMD_DR_Dx       (AMD_HY_D0)
+#define	AMD_DRBH_Cx       (AMD_DR_Cx | AMD_HY_D0 )
 #define AMD_DRBA23_RBC2 (AMD_DR_BA | AMD_DR_B2 | AMD_DR_B3 | AMD_RB_C2 )