[coreboot] [commit] r5718 - in trunk/src/mainboard/jetway: . pa78vm5 pa78vm5/acpi

[Peter Stuge]

repository service wrote:
> --- trunk/src/mainboard/amd/tilapia_fam10/chip.h	Tue Aug 17 13:32:21 2010	(r5716)
> +++ trunk/src/mainboard/jetway/pa78vm5/chip.h	Tue Aug 17 17:19:32 2010	(r5718)
..
> @@ -21,6 +22,4 @@
>  extern struct chip_operations mainboard_ops;
>  
>  struct mainboard_config {
> -//	int fixup_scsi;
> -//	int fixup_vga;
>  };
> 

Should this be applied also to the tilapia_fam10 board?


> +++ trunk/src/mainboard/jetway/pa78vm5/romstage.c	Tue Aug 17 17:19:32 2010	(r5718)
..
> @@ -81,6 +88,7 @@
>  
>  #include "northbridge/amd/amdfam10/amdfam10.h"
>  
> +
>  #include "northbridge/amd/amdfam10/raminit_sysinfo_in_ram.c"
>  #include "northbridge/amd/amdfam10/amdfam10_pci.c"
>  
> @@ -95,7 +103,7 @@
>  #include "northbridge/amd/amdfam10/early_ht.c"
>  #include "southbridge/amd/sb700/sb700_early_setup.c"
>  
> -//#include "spd_addr.h"
> +
>  
>  #define RC00  0
>  #define RC01  1
> @@ -136,7 +144,7 @@
>  	enable_rs780_dev8();
>  	sb700_lpc_init();
>  
> -	it8718f_enable_serial(0, CONFIG_TTYS0_BASE);
> +	f71863fg_enable_serial(SERIAL_DEV, CONFIG_TTYS0_BASE);
>  	uart_init();
>  	console_init();
>  	printk(BIOS_DEBUG, "\n");
> @@ -250,7 +258,6 @@
>  //	ram_check(0x00200000, 0x00200000 + (640 * 1024));
>  //	ram_check(0x40200000, 0x40200000 + (640 * 1024));
>  
> -
>  //	die("After MCT init before CAR disabled.");
>  
>  	rs780_before_pci_init();
> @@ -261,3 +268,4 @@
>  	post_cache_as_ram();	// BSP switch stack to ram, copy then execute LB.
>  	post_code(0x43);	// Should never see this post code.
>  }
> +

Please try very hard to avoid that this kind of whitespace changes is
included in patches since they make careful review a MUCH longer
process, and they can also be problematic if there is a need to trace
history in the repository.

I recommend to always run svn diff | less and manually review first,
before sending a patch. These changes are usually easy to discover
when you are the author of a patch, but they are much more difficult
to skip over for reviewers.

Thank you.


//Peter