[coreboot] mainboard.c: init() still being called?

[Stefan Reinauer]

 Hi Jens,

On 8/16/10 3:57 PM, Jens Rottmann wrote:
> The old code defined a config byte (for some GPIOs) in struct
> mainboard_lippert_spacerunner_lx_config (chip.h), which used to be set in
> Config.lb with a simple register "..." = "..." statement and used in
> mainboard.c's init() by casting dev->chip_info to struct
> mainboard_lippert_spacerunner_lx_config.
>
> The current code still has the struct (renamed to mainboard_config), but while
> changing Config.lb to devicetree.cb the register statement got dropped so
> there's no longer any value assigned to the config byte. I tried to re-add the
> register line where it was before (before chip northbridge/...) but this seems
> no longer to be allowed. And more importantly, init() which uses the config byte
> is still there but does not seem to be executed any more. At least I couldn't
> see its debug output.
Does the following patch fix the problem for you?

Index: src/Kconfig
===================================================================
--- src/Kconfig (revision 5692)
+++ src/Kconfig (working copy)
@@ -740,7 +740,7 @@

config WARNINGS_ARE_ERRORS
bool
- default y
+ default n

config ID_SECTION_OFFSET
hex
Index: src/mainboard/lippert/spacerunner-lx/devicetree.cb
===================================================================
--- src/mainboard/lippert/spacerunner-lx/devicetree.cb (revision 5692)
+++ src/mainboard/lippert/spacerunner-lx/devicetree.cb (working copy)
@@ -1,3 +1,7 @@
+# See also SMC_CONFIG in cache_as_ram_auto.c.
+# Bit0 turns off Live LED, bit1 switches Com1 to RS485, bit2 same for Com2.
+register "sio_gp1x_config" = "0x01"
+
chip northbridge/amd/lx
device pci_domain 0 on
device pci 1.0 on end # Northbridge

Stefan


-- 
coresystems GmbH • Brahmsstr. 16 • D-79104 Freiburg i. Br.
      Tel.: +49 761 7668825 • Fax: +49 761 7664613
Email: info at coresystems.de  • http://www.coresystems.de/
Registergericht: Amtsgericht Freiburg • HRB 7656
Geschäftsführer: Stefan Reinauer • Ust-IdNr.: DE245674866