[coreboot] Warnings

Stefan Reinauer stepan at coresystems.de
Fri Apr 30 22:22:07 CEST 2010


On 4/30/10 10:17 PM, Myles Watson wrote:
>>> src/northbridge/amd/lx/raminit.c:334: warning: array subscript is
>>> above array bounds
>>>
>>>
>>> Marc indicated, this could be a compiler "problem". We could maybe add an
>>> explicit check for the array index.
>>>       
>> It looks like it's being indexed by a function that's built into the
>> compiler that returns bit positions.  Since the return value could be
>> up to 31, I think it's a correct warning (the array's only got 8
>> elements.)
>>     
> This patch fixes the warnings.  All I did was factor out the identical
> code into a function, and remove some unnecessary casts.  So I guess I
> was wrong.
>
> Signed-off-by: Myles Watson <mylesgw at gmail.com>
>   
Acked-by: Stefan Reinauer <stepan at coresystems.de>

-- 
coresystems GmbH • Brahmsstr. 16 • D-79104 Freiburg i. Br.
      Tel.: +49 761 7668825 • Fax: +49 761 7664613
Email: info at coresystems.dehttp://www.coresystems.de/
Registergericht: Amtsgericht Freiburg • HRB 7656
Geschäftsführer: Stefan Reinauer • Ust-IdNr.: DE245674866





More information about the coreboot mailing list